Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change URI methods - 3.0.0 #112

Merged
merged 13 commits into from
Apr 13, 2021
Merged

Change URI methods - 3.0.0 #112

merged 13 commits into from
Apr 13, 2021

Conversation

Canato
Copy link
Member

@Canato Canato commented Apr 13, 2021

close #99
fix #83
fix #84

Description:

Most of the usage of this library expect the URI to be a file path, what is not it main propose.
Based on this was decided to split into two methods and remove the old method.

This will break the contract, making us release a new major version (3.0.0)

Should be a small a specific change so we will avoid to deprecate.

Open for suggestions in how to do and naming. Please open a discussion for it.

For now, the possible names:

  • getUriFilePath
  • getUriContent

keeping the uri term in both names is done on propose so the users can easily find.

Check list for the Code Reviewer:

  • CHANGELOG
  • README
  • Wiki
  • Version Number

@Canato Canato requested a review from a team as a code owner April 13, 2021 08:24
@Canato Canato merged commit 82c66e7 into main Apr 13, 2021
@Canato Canato deleted the add_file_path branch April 13, 2021 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant