Close CropActivity if returning back from camera app without taking picture. #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Close crop activity when user returns from camera app without taking picture ( back button) , in that case crop activity must not be shown.
Close crop activity
|
Thanks @ArmChilingarov could you please update the CHANGELOG? |
|
Done |
Canato
requested changes
Dec 13, 2021
Co-authored-by: Canato <vcanato@gmail.com>
Canato
approved these changes
Dec 13, 2021
This was referenced Feb 2, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close crop activity when user returns from camera app without taking picture ( back button) , in that case crop activity must not be shown.
how to reproduce/test
click TAKE CAMERA PIC ... WITH URI, when camera opens , click back button .
It still shows the crop activity , without any image, but should close the activity when TakeCamera() contract result is null or false.