Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CropImageView: Use customOutputUri instance property as a fallback in startCropWorkerTask. #401

Merged
merged 1 commit into from
Jun 29, 2022
Merged

CropImageView: Use customOutputUri instance property as a fallback in startCropWorkerTask. #401

merged 1 commit into from
Jun 29, 2022

Conversation

vanniktech
Copy link
Contributor

I was surprised when setting view.customOutputUri didn't do what I thought it did when manually calling croppedImageAsync which internally calls startCropWorkerTask.

@vanniktech vanniktech requested a review from a team as a code owner June 28, 2022 18:32
Canato
Canato approved these changes Jun 29, 2022
View reviewed changes
Copy link
Member

@Canato Canato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this

@Canato Canato merged commit b8ae101 into CanHub:main Jun 29, 2022
@vanniktech vanniktech deleted the crop-iamge-view-custom-uri-fix branch June 29, 2022 14:18
@Canato Canato mentioned this pull request Jul 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Canato Canato Canato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vanniktech @Canato