Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/bitmap null #70

Merged
merged 5 commits into from
Feb 26, 2021
Merged

Bug/bitmap null #70

merged 5 commits into from
Feb 26, 2021

Conversation

Canato
Copy link
Member

@Canato Canato commented Feb 26, 2021

close #49

Description:

The library could not return a bitmap form CropImage when using Activity Result, because of the size of the bitmap that couldn't fit in the Activity Parcel.

Instead of treating like a bug, this is the correct behaviour. So was created a new function

/**
     * The cropped image bitmap result.<br>
     * Null if save cropped image was executed, no output requested or failure.
     *
     * @param context used to retrieve the bitmap in case you need from activity result
     */
    public Bitmap getBitmap(@NonNull Context context) { .. }

Check list for the Code Reviewer:

  • CHANGELOG
  • README
  • Wiki
  • Version Number

@Canato Canato requested a review from a team as a code owner February 26, 2021 13:38
@Canato Canato self-assigned this Feb 26, 2021
@Canato Canato merged commit e2d1a04 into main Feb 26, 2021
@Canato Canato deleted the bug/bitmap_null branch February 26, 2021 13:55
@Morons
Copy link
Contributor

Morons commented Feb 28, 2021

I use MongoDb and store my Images as base64 encoded strings, with a mongoDB can only store files up to 16MB, Over that we use GridFS to split the files and create a "Pointer" document to reference the parts. So the maximum image/multimedia can be <16MB
If that will help you scale the problem,
Other wise perhaps ask if image can be scaled to fit? - Or just Scale it anycase.

Thanx for this solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CropImage.getActivityResult(data).bitmap = NULL
2 participants