-
-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to disable translation of the crop window #79
Conversation
This conflicts very minorly with #76, so I suggest we merge than one first and then I'll fix up the conflicts. |
Meta point: I realize that these features might not be popular - they're just something I need that I might as well share. I definitely want to use this library rather than rolling my own as it is high quality. This is the last feature that I need to add. Feel free to push back against this if you don't think this feature should be added - it's no problem for me to fork the repo. |
I believe it is not a problem, since it can be useful for more people. We just need to be sure that the default value keeps the expected behaviour. Because of the possible misinterpretation of |
fcff5cc
to
7c65036
Compare
I've renamed it |
f914ffe
to
9f5fdb1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
Let me know, when is over.
Please don't forget to add setCenterMoveEnabled()
into Sample/CameraFragment
on the methods startCameraWithoutUri
and startCameraWithUri
@Canato OK I think this is done. I can't see anything else that needs changing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
close #78
Template 1 [New Feature]
Description:
Added new option to disable translating of the crop window by dragging the center.
Most of the changes here were boilerplate changes. I used the
multiTouch
option as a template to make sure I added the option to all the places it was required, such as XML, CropImageView and ActivityBuilder. I also added the toggle to the sample app.The functional change is that, when this toggle is disabled, dragging from the center of the crop window does nothing.
Check list for the Code Reviewer: