Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Spark SQL data source #708

Open
andreashimin opened this issue Oct 3, 2024 · 8 comments
Open

Support Spark SQL data source #708

andreashimin opened this issue Oct 3, 2024 · 8 comments

Comments

@andreashimin
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Provides users with the ability to connect and set up Spark SQL as a data source, enabling integration with distributed data processing frameworks directly within Wren AI's connection setup.

Describe the solution you'd like

  • Add a Spark SQL connector in ibis-server
  • Implement Spark SQL connection handling between ibis-server and Wren UI backend.
  • Create a UI form for users to set up the Spark SQL data source (e.g., server address, port, authentication).

For more details, see Creating a New Data Source Connector in our CONTRIBUTING.md.

Additional context
Add any other context or screenshots about the feature request here.

@goldmedal
Copy link
Contributor

goldmedal commented Oct 3, 2024

The first step of this issue is implementing the SparkSQL connector on Wren engine side. Wren engine is powered by ibis-project to connect to different data sources.

Refer to ibis pyspark backend, you can follow the guide of adding DataSource to:

  • define the connection info
  • add the connector
  • add test cases

By the way, It would be appreciated if you could also survey how to connect to Databricks using ibis-project. 🙇

@ichuniq
Copy link

ichuniq commented Oct 6, 2024

Hi I'm new to this project and would like to work on this.

@chilijung
Copy link
Member

@ichuniq great! Here you go!

@Prototype4988
Copy link
Contributor

@chilijung Since there hasnt been any updates for this issue, I hope you dont mind if i can have a look at it.

@chilijung
Copy link
Member

@Prototype4988 Sure go ahead!

@chilijung chilijung assigned Prototype4988 and unassigned ichuniq Oct 28, 2024
@chilijung
Copy link
Member

chilijung commented Oct 29, 2024

@ichuniq Are you working on this? I noticed you submitted a PR for a typo. I think you may be looking into this issue. Please help confirm. If yes, could you also share the correct progress? Thanks.

@Prototype4988 before you start, let me double check and confirm with @ichuniq thanks.

@ichuniq
Copy link

ichuniq commented Oct 29, 2024

Hi @chilijung, I’ve looked into the task but haven’t started implementing it yet due to limited capacity. However, I’ll have some free time between now and the end of October.

@chilijung
Copy link
Member

Thank you for the update, @Prototype4988. I will find other issues for you to solve, and I've cc'd you on other ones.

@ichuniq , I look forward to your contribution, and please keep us updated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants