-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixed a bug for the error which was shown when waiting for response #719
Conversation
relates to #699 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your effort in addressing this bug! I noticed that the issue is not fully resolved yet. Specifically, the warning message still appears but doesn’t reflect the expected behavior.
It might be helpful to review the askProcessState-related flow.
I appreciate your continued work on this and look forward to the next iteration. Please feel free to reach out if you need any further assistance with this issue.
Can you please provide me exact steps to reproduce this? I don't see that banner. Screen.Recording.2024-10-04.at.10.46.57.AM.mov |
Your steps to reproduce the problem are correct. Hi @sahil9001, Feel free to tag me when your PR is ready for review. Thanks, |
…or response" This reverts commit 697766a.
@fredalai Thanks, I got it, please check now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sahil9001 Thank you for your contribution and the effort you put into resolving the issue. Looking forward to more collaborations in the future! :D
@fredalai This is eligible for Hacktoberfest Swag, right? I can't see a form to fill |
Hi @sahil9001, @chilijung will reply to you soon. :D |
Hi @sahil9001, congratulations on your amazing contribution! Please join our Discord channel https://discord.gg/Eg7VY6nYY5 and send me a direct message. I'll send you the form to fill out! |
…for response (Canner#719) * fix: fixed a bug for the error which was shown when waiting for response * feat: added resetState on submit ask * Revert "fix: fixed a bug for the error which was shown when waiting for response" This reverts commit 697766a.
No description provided.