Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed a bug for the error which was shown when waiting for response #719

Merged
merged 3 commits into from
Oct 4, 2024

Conversation

sahil9001
Copy link
Contributor

No description provided.

@sahil9001
Copy link
Contributor Author

relates to #699

Copy link
Contributor

@fredalai fredalai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your effort in addressing this bug! I noticed that the issue is not fully resolved yet. Specifically, the warning message still appears but doesn’t reflect the expected behavior.

It might be helpful to review the askProcessState-related flow.

I appreciate your continued work on this and look forward to the next iteration. Please feel free to reach out if you need any further assistance with this issue.

@sahil9001
Copy link
Contributor Author

Can you please provide me exact steps to reproduce this? I don't see that banner.

Screen.Recording.2024-10-04.at.10.46.57.AM.mov

@fredalai
Copy link
Contributor

fredalai commented Oct 4, 2024

Can you please provide me exact steps to reproduce this? I don't see that banner.

Screen.Recording.2024-10-04.at.10.46.57.AM.mov

Your steps to reproduce the problem are correct.
I saw 0:24 seconds in the video

截圖 2024-10-04 下午3 10 22

Hi @sahil9001,
Great job! Your final commit is correct. We don’t need the initial commit, so please clean up the commits.

Feel free to tag me when your PR is ready for review.

Thanks,
Freda

@sahil9001
Copy link
Contributor Author

@fredalai Thanks, I got it, please check now

Copy link
Contributor

@fredalai fredalai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sahil9001 Thank you for your contribution and the effort you put into resolving the issue. Looking forward to more collaborations in the future! :D

@fredalai fredalai merged commit d9f86e6 into Canner:main Oct 4, 2024
3 checks passed
@sahil9001
Copy link
Contributor Author

@fredalai This is eligible for Hacktoberfest Swag, right? I can't see a form to fill

@fredalai
Copy link
Contributor

fredalai commented Oct 4, 2024

Hi @sahil9001,

@chilijung will reply to you soon. :D

@chilijung
Copy link
Member

Hi @sahil9001, congratulations on your amazing contribution! Please join our Discord channel https://discord.gg/Eg7VY6nYY5 and send me a direct message. I'll send you the form to fill out!

AryanK1511 pushed a commit to AryanK1511/WrenAI that referenced this pull request Oct 7, 2024
…for response (Canner#719)

* fix: fixed a bug for the error which was shown when waiting for response

* feat: added resetState on submit ask

* Revert "fix: fixed a bug for the error which was shown when waiting for response"

This reverts commit 697766a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants