Added TrustServerCertificate param in connectionInfo #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wwwy3y3 @grieve54706 It is ready to review ! |
grieve54706
suggested changes
Oct 15, 2024
|
I already doubted it. Anyways, I will do it. |
|
@grieve54706 Please review it, I have configured Trust Server Certificate property. |
|
@wwwy3y3 Could you assign someone in web team to review this? |
|
@andreashimin will help review |
There was a problem hiding this comment.
Hi @himanshu634, I saw there is a conflict in this PR,
Could you help rebase it? Thank you
wren-ui/src/components/pages/setup/dataSources/SQLServerProperties.tsx
Outdated
Show resolved
Hide resolved
|
@andreashimin Please check now, thanks. |
|
Hi @himanshu634 , Thank you for your contribution 👍🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added TrustServerCertificate param in connectionInfo as described here.