Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update dead links in docker/README.md #769

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

vil02
Copy link
Contributor

@vil02 vil02 commented Oct 17, 2024

I found some dead links in /docker/README.md and I decided to fix them. Please note that I used the absolute link, because such approach was used in case of wren-engine /example.

@vil02 vil02 force-pushed the update_dead_links_in_docker_README_md branch from 685992b to 01378f4 Compare October 18, 2024 12:01
@paopa paopa self-requested a review October 21, 2024 07:54
Copy link
Member

@paopa paopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @vil02, Thank you for the work to fix README. LGTM. have a minor comment only!

docker/README.md Outdated Show resolved Hide resolved
Co-authored-by: Piotr Idzik <65706193+vil02@users.noreply.github.com>
Copy link
Member

@paopa paopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @vil02, LGTM. Thanks for your contribution again!

@paopa paopa merged commit c9706b5 into Canner:main Oct 22, 2024
3 checks passed
@vil02 vil02 deleted the update_dead_links_in_docker_README_md branch October 22, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants