chore(wren-ai-service): minor updates #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
cyyeh
commented
Oct 28, 2024
•
cyyeh
commented
- add timezone support to sql expansion and ask apis
- add timeout(30 seconds) to the engine execute_sql method
- fix timeout issue for openai llm
- add language support for sql2answer
- running sql correction concurrently
cyyeh
added
module/ai-service
cyyeh
changed the title
cyyeh
force-pushed
the
chore/ai-service/fix-pipeline
branch
from
03c239e to
88cab64
Compare
cyyeh
force-pushed
the
chore/ai-service/fix-pipeline
branch
from
88cab64 to
a5c5ded
Compare
paopa
reviewed
Oct 31, 2024
wren-ai-service/src/__main__.py
Outdated
| @@ -100,6 +100,7 @@ async def exception_handler(request, exc: Exception): | |||
|
|
|||
| @app.exception_handler(RequestValidationError) | |||
| async def request_exception_handler(request, exc: Exception): | |||
| print(str(exc)) | |||
There was a problem hiding this comment.
I think we could remove printing the exception here, FastAPI handle the exception and also leave the log in console
Comment on lines
+116
to
+130
| replies: List[str] | List[List[str]], | ||
| project_id: str | None = None, | ||
| ) -> dict: | ||
| try: | ||
| cleaned_generation_result = orjson.loads( | ||
| clean_generation_result(replies[0]) | ||
| )["results"] | ||
| if isinstance(replies[0], dict): | ||
| cleaned_generation_result = [ | ||
| orjson.loads(clean_generation_result(reply["replies"][0]))[ | ||
| "results" | ||
| ][0] | ||
| for reply in replies | ||
| ] | ||
| else: | ||
| cleaned_generation_result = orjson.loads( | ||
| clean_generation_result(replies[0]) | ||
| )["results"] |
There was a problem hiding this comment.
I'm wondering to know which scenario we encountered to do the change
| @@ -57,7 +57,7 @@ def __init__( | |||
| ) | |||
|
|
|||
| @component.output_types(embedding=List[float], meta=Dict[str, Any]) | |||
| @backoff.on_exception(backoff.expo, openai.RateLimitError, max_time=60, max_tries=3) | |||
| @backoff.on_exception(backoff.expo, openai.APIError, max_time=60.0, max_tries=3) | |||
There was a problem hiding this comment.
im curious about why we change the backoff error
Comment on lines
47
to
50
| configurations: Optional[AskConfigurations] = AskConfigurations( | ||
| language="English", | ||
| timezone=AskConfigurations.Timezone(name="Asia/Taipei", utc_offset="+8:00"), | ||
| ) |
There was a problem hiding this comment.
nitpick: i think we give the default value in class, thus skipping here can make code more clear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.