-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Face issue when testing the VulcanSQL integration with Canner Enteprise #185
Conversation
… to summary and operationId in spec of artifact. - display indicator files of each workspace when log debug info at "CannerPersistenceStore" and "CannerProfileReader" - support adding workspace sql name prefix to summary and operationId in spec of artifact in the "CannerPersistenceStore"
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## develop #185 +/- ##
===========================================
+ Coverage 91.07% 91.30% +0.23%
===========================================
Files 328 319 -9
Lines 5399 5105 -294
Branches 718 677 -41
===========================================
- Hits 4917 4661 -256
+ Misses 343 314 -29
+ Partials 139 130 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
- add some debug logger for providing information about "Evaluator" and "CannerPersistenceStore" - fix the non-consistency canner profile name in "CannerProfileReader". - fix missing the root path when download buffer stream of the artifact - update th test cases
fca8e87
to
2d530cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Faced the issues when testing the VulcanSQL Integration with Canner Enterprise:
API Documentation is not consistent for the API prefix when getting the artifacts from Canner Enterprise and merging to one artifact, we need to make the
operationId
andsummary
field add the workspace SQL name inspecs
, then it could solve the solution.The generated canner profile name in
CannerProfileReader
is not the same asCannerPersistenceStore
, so we need to fix it to the samecanner-{workspaceSqlName}
.Issue ticket number
closes N/A
Screenshot for integrating with Canner Enterprise.
We opened a Canner Enterprise of PR testing env and create two workspaces
w1
andw2
with the tables:Use the In the VulcanSQL
labs
and create two profilescanner-w1
andcanner-w2
with temporal PAT fo connecting Canner Enterprise byextension-driver-canner
through PG Wire Protocol:Below, we put the two SQL with API Schema definition to query
w1
and runvulcan build
for building the SQL and API schema to the artifact forw1
Upload them to Canner Enterprise, and see the uploaded artifacts in VulcanSQL folder of
w1
:Do the same steps for
w2
, put the two SQL with API Schema definition to queryw2
and runvulcan build
for building the SQL and APIUpload them to Canner Enterprise, and see the uploaded artifacts in VulcanSQL folder of
w2
:Now we delete the SQLs and API schemas files, in the
lasbs
project, and update thevulcan.yaml
forartifact
options,extensions
andprofiles
like below to use the Canner extension:HINT: currently, the extension not include Canner PAT authenticator, because it's developing, so we will make
auth
options keepenabled: false
.Then set some environment variables we need:
Finally, run
vulcan serve
to fetch the artifacts from Canner Enterprise, and generate Canner Enterprise Profiles settings:Open the API documentation URL, we will see the workspace SQL Name in the prefix for the
w1
andw2
Data API:Send request to
/api/w1/activity_logs?operation=VIEW
to query and you will see the result:Send request to
/api/w2/resource_metadata?data_type=DATA_SOURCE_TABLE
to query and you will see the result:You could also see the logs in VulcanSQL:
Done :)
Additional Context
logger.debug
could see the workspaces indicator information inCannerProfileReader
andCannerPersistenceStore
.@VulcanInternalExtension()
inCannerProfileReader
andCannerPersistenceStore
, because both of them are not internal extensions, thet load by external extension type, so theVulcanInternalExtension
won't be used