Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Catalog run with docker when calling by binary #200

Merged
merged 8 commits into from
Jun 29, 2023

Conversation

andreashimin
Copy link
Contributor

@andreashimin andreashimin commented Jun 27, 2023

Description

  1. Catalog run with docker when calling by binary
  2. Replace the template file extension .js with .template, preventing detecting require next by pkg.
  3. Add Catalog publish docker & build docker cmd in project.json
  4. Support API without parameter in Catalog UI
  5. Fix Catalog docker packager template
  6. Remove pkg packager in this repo since we moved to another repo

Issue ticket number

closes N/A

Additional Context

@vercel
Copy link

vercel bot commented Jun 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vulcan-sql-document ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 29, 2023 6:24am

@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2023

Codecov Report

Patch coverage: 20.83% and project coverage change: -0.44 ⚠️

Comparison is base (b53012c) 91.00% compared to head (f1f2ca0) 90.56%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #200      +/-   ##
===========================================
- Coverage    91.00%   90.56%   -0.44%     
===========================================
  Files          331      331              
  Lines         5445     5471      +26     
  Branches       728      730       +2     
===========================================
  Hits          4955     4955              
- Misses         345      373      +28     
+ Partials       145      143       -2     
Flag Coverage Δ
build 90.55% <100.00%> (ø)
catalog-server 100.00% <ø> (ø)
cli 75.85% <17.39%> (-5.63%) ⬇️
integration-testing 90.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/cli/src/commands/catalog.ts 25.80% <17.39%> (-17.53%) ⬇️
...s/build/src/models/extensions/packager/packager.ts 67.85% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@onlyjackfrost onlyjackfrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@fredalai fredalai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreashimin andreashimin merged commit 89d6bd8 into develop Jun 29, 2023
@hanshino hanshino deleted the feature/cli-catalog branch January 31, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants