-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Correct the profile of cache layer schema for Canner Persistence Store #276
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
93266d2
to
79ec99b
Compare
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## develop #276 +/- ##
========================================
Coverage 90.20% 90.21%
========================================
Files 350 350
Lines 5965 5967 +2
Branches 803 803
========================================
+ Hits 5381 5383 +2
+ Misses 424 423 -1
- Partials 160 161 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
This reverts commit e081f2a.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Description
For the Canner Enterprise product, the extension-store-canner pulls the result.json from Minio to merge into one file, it lacks the profile setting of the cache layer in the schema, so we need to fix it and let caching datasets functionality works.
Issue ticket number
closes #275
Screenshot for integrating with Canner Enterprise.
Step 1: Check the connection and deploy Data API to the Canner Enterprise product
Step 1-1
Opened a Canner Enterprise of PR testing env and create the
w1
workspaces with the table:Step 1-2.1
Use the In the VulcanSQL labs and create canner-w1 profiles with temporal PAT for connecting Canner Enterprise by extension-driver-canner through PG Wire Protocol:
Step 1-2.2
Enable caching for vulcan.yaml
Step 1-2.3
Apply my bugfix code for
package.json
of labsStep 1-3
Prepare Data APIs
Step 1-4
Add pkg-extension-store-canner in the Makefile and execute it
(Get the result.json)
Step 1-5
Upload them to Canner Enterprise, and see the uploaded artifacts in the vulcansql folder of w1:
Step 2: Check CannerPersistenceStore
Now we delete the SQLs and API schemas files, in the lasbs project, and update the vulcan.yaml for artifact options, extensions and profiles like below to use the Canner extension:
Step 2-1
Step 2-2
Then set some environment variables we need:
Step 2-3.1
Finally, run vulcan serve to fetch the artifacts from Canner Enterprise, and generate Canner Enterprise Profiles settings:
Step 2-3.2
Open the API documentation URL, we will see the workspace SQL Name in the prefix for the w1 Data API:
Step 2-3.3
Send request to
/api/w1/activity_logs?operation=LOGIN
to query and you will see the result:Done.
Additional Context
I will revert #273 in this PR as it was causing bugs with the Canner integration. It seems that this issue needs to be discussed in an Issue. cc @cyyeh