-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: caching layer persistent #283
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## develop #283 +/- ##
===========================================
+ Coverage 90.09% 90.14% +0.05%
===========================================
Files 353 353
Lines 6077 6090 +13
Branches 824 829 +5
===========================================
+ Hits 5475 5490 +15
+ Misses 440 438 -2
Partials 162 162
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
9505a8a
to
453d8a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
const parquetFiles = []; | ||
for (const file of files) { | ||
if (/\.parquet$/.test(file)) { | ||
parquetFiles.push(file); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(NIT) Prefer functional programming for filtering
const parquetFiles = files.filter(file => /\.parquet$/.test(file))
Description