Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: extends CacheLayerInfo interface and Profile interface #310

Merged
merged 4 commits into from
Sep 18, 2023

Conversation

onlyjackfrost
Copy link
Contributor

@onlyjackfrost onlyjackfrost commented Sep 18, 2023

Description

Extends CacheLayerInfo interface and Profile interface to store properties that pass to the data source.

profile.yaml

 - name: duckdb
    type: duckdb
   connection:
      host: ...
      otherConnectionInfo
   allow: *
   // new added
   properties:
      some-configuration that can be read in the setting

API schema

urlPath: /artist/:id
cache:
 - cacheTableName: foo
   sql: 'select 1'
   profile: duckdb
   // new added
   options:
      foo: bar
profile: duckdb

Test:

manul test using labs
image

to store properties passed to datasource.
@vercel
Copy link

vercel bot commented Sep 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vulcan-sql-document ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2023 9:20am

@onlyjackfrost onlyjackfrost changed the title Feature: extends CacheLayerInfo interface & Profile interface Feature: extends CacheLayerInfo interface and Profile interface Sep 18, 2023
Copy link
Contributor

@kokokuo kokokuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kokokuo kokokuo merged commit 2f212a1 into develop Sep 18, 2023
2 checks passed
@hanshino hanshino deleted the feature/cache-impersonate branch January 31, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants