Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: query again instead of using cached result when exporting from canner #326

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

onlyjackfrost
Copy link
Contributor

@onlyjackfrost onlyjackfrost commented Jan 11, 2024

Description

This PR fix the issue #324 according to the Canner API Documentation

Issue ticket number

#324

Copy link

vercel bot commented Jan 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
vulcan-sql-document ✅ Ready (Inspect) Visit Preview Jan 11, 2024 8:04am

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f7fb0de) 89.75% compared to head (293b97c) 89.75%.
Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #326   +/-   ##
========================================
  Coverage    89.75%   89.75%           
========================================
  Files          366      366           
  Lines         6363     6363           
  Branches       878      878           
========================================
  Hits          5711     5711           
  Misses         476      476           
  Partials       176      176           
Flag Coverage Δ
extension-driver-canner 80.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kokokuo kokokuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@onlyjackfrost onlyjackfrost merged commit c899a3a into develop Jan 11, 2024
6 checks passed
@hanshino hanshino deleted the fix/issue-324 branch January 31, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants