Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Solution.ID for YAML generated objects #691

Closed
ischoegl opened this issue Aug 13, 2019 · 0 comments · Fixed by #696
Closed

Incorrect Solution.ID for YAML generated objects #691

ischoegl opened this issue Aug 13, 2019 · 0 comments · Fixed by #696
Labels

Comments

@ischoegl
Copy link
Member

ischoegl commented Aug 13, 2019

Cantera version

2.5.0a3

Python version

3.6

Expected Behavior

gas.ID should provide the ID of the phase, with the default being taken from the input file. I.e.

gas = ct.Solution('nDodecane_Reitz.yaml')
print(gas.ID)

should be nDodecane_RK. I.e. the result should be identical to the one obtained if one were to import the CTI file. Explicitly specifying the phase (i.e. nDodecane_RK or nDodecane_IG) will not change the behavior.

Actual Behavior

gas = ct.Solution('nDodecane_Reitz.yaml')
print(gas.ID)

yields <phase>, regardless of the mechanism that is imported.

Steps to reproduce

See above.

Fix involves ThermoFactory.cpp#L450

ischoegl pushed a commit to ischoegl/cantera that referenced this issue Aug 16, 2019
ischoegl pushed a commit to ischoegl/cantera that referenced this issue Aug 16, 2019
* Resolve conflation of gas.ID and gas.name in unit tests
* Also fixes Cantera#691
ischoegl pushed a commit to ischoegl/cantera that referenced this issue Sep 24, 2019
* Resolve conflation of gas.ID and gas.name in unit tests
* Also fixes Cantera#691
ischoegl pushed a commit to ischoegl/cantera that referenced this issue Sep 29, 2019
* Resolve conflation of gas.ID and gas.name in unit tests
* Also fixes Cantera#691
speth pushed a commit that referenced this issue Oct 23, 2019
* Resolve conflation of gas.ID and gas.name in unit tests
* Also fixes #691
decaluwe pushed a commit to gkogekar/cantera that referenced this issue Dec 20, 2019
* Resolve conflation of gas.ID and gas.name in unit tests
* Also fixes Cantera#691
srikanthallu pushed a commit to srikanthallu/cantera that referenced this issue Sep 17, 2020
* Resolve conflation of gas.ID and gas.name in unit tests
* Also fixes Cantera#691
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants