Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delegate reactor implementation to user-provided Python classes #1003

Merged
merged 49 commits into from
Dec 31, 2021

Commits on Dec 31, 2021

  1. Configuration menu
    Copy the full SHA
    df6ba5f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3f6cc82 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    af209a9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5c85ec6 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9c75c36 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    88c9f45 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    42abbef View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    e38145f View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    a347407 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    f6d3463 View commit details
    Browse the repository at this point in the history
  11. Revise behavior of "after" delegates that return a value

    For 'after' delegates, if the return code from the wrapped function is
    non-zero, then the delegate's return value will be the sum of the
    values from the base and wrapped functions.
    speth committed Dec 31, 2021
    Configuration menu
    Copy the full SHA
    ce197ba View commit details
    Browse the repository at this point in the history
  12. [Python] Prefix replacement delegate methods with 'replace_'

    Avoids name clashes with existing Python names that may have different
    method signatures, e.g. Reactor.get_state.
    speth committed Dec 31, 2021
    Configuration menu
    Copy the full SHA
    54806d8 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    b0aa180 View commit details
    Browse the repository at this point in the history
  14. [Reactor] Introduce simpler function for reactor ODE function

    The function for evaluating dy/dt no longer needs the vector of
    sensitivity parameters, and should not operate directly on the state
    vector (which should be processed by updateState).
    speth committed Dec 31, 2021
    Configuration menu
    Copy the full SHA
    11deb92 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    28436c1 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    4f5f2d4 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    95c5d58 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    8a834c3 View commit details
    Browse the repository at this point in the history
  19. Added RHS and LHS user variables to Reactor class

    Implemented LHS/RHS notation in eval functions of Reactor classes
    chinahg authored and speth committed Dec 31, 2021
    Configuration menu
    Copy the full SHA
    6a06560 View commit details
    Browse the repository at this point in the history
  20. Created new setDelegate method for void(double, double*, double*) type

    Required for LHS/RHS arguments
    
    Added name to authors list
    chinahg authored and speth committed Dec 31, 2021
    Configuration menu
    Copy the full SHA
    6155ea2 View commit details
    Browse the repository at this point in the history
  21. Minor formatting changes

    Whitespace deletions, unnecessary comment removal, Doxygen string formatting
    chinahg authored and speth committed Dec 31, 2021
    Configuration menu
    Copy the full SHA
    6925df6 View commit details
    Browse the repository at this point in the history
  22. Fix custom2.py to use RHS/LHS eval function

    Co-authored-by: Ray Speth <speth@mit.edu>
    chinahg and speth committed Dec 31, 2021
    Configuration menu
    Copy the full SHA
    7e22e49 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    8a40d1e View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    c5370ba View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    e8a1ce3 View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    c38266c View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    495ba2a View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    ce86d11 View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    dcdaa98 View commit details
    Browse the repository at this point in the history
  30. [Kinetics] Make "declared-species" option work for surfaces

    When adding reactions, the check for whether or not surface sites are
    conserved needs to occur after the check for whether all species in the
    reaction exist, since the number of sites isn't known for an undefined
    species.
    speth committed Dec 31, 2021
    Configuration menu
    Copy the full SHA
    2edd92f View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    9ca5583 View commit details
    Browse the repository at this point in the history
  32. [Reactor] Modify signature of evalSurfaces

    This signature makes it possible to write delegates for this function
    that change the gas phase species production rates
    speth committed Dec 31, 2021
    Configuration menu
    Copy the full SHA
    d2394f3 View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    b46bfcf View commit details
    Browse the repository at this point in the history
  34. Configuration menu
    Copy the full SHA
    71c2276 View commit details
    Browse the repository at this point in the history
  35. Configuration menu
    Copy the full SHA
    e0fc51f View commit details
    Browse the repository at this point in the history
  36. Configuration menu
    Copy the full SHA
    f415c2c View commit details
    Browse the repository at this point in the history
  37. [Python/Reactor] Sync state when accessing ReactorSurface.kinetics

    This is analogous to the automatic synchronization done when accessing
    Reactor.thermo.
    speth committed Dec 31, 2021
    Configuration menu
    Copy the full SHA
    1f68233 View commit details
    Browse the repository at this point in the history
  38. Configuration menu
    Copy the full SHA
    a161f26 View commit details
    Browse the repository at this point in the history
  39. Configuration menu
    Copy the full SHA
    7b667d7 View commit details
    Browse the repository at this point in the history
  40. Configuration menu
    Copy the full SHA
    ccf03a9 View commit details
    Browse the repository at this point in the history
  41. Configuration menu
    Copy the full SHA
    4d0039e View commit details
    Browse the repository at this point in the history
  42. Configuration menu
    Copy the full SHA
    58c218d View commit details
    Browse the repository at this point in the history
  43. Configuration menu
    Copy the full SHA
    d6bd8c7 View commit details
    Browse the repository at this point in the history
  44. Configuration menu
    Copy the full SHA
    1035b7e View commit details
    Browse the repository at this point in the history
  45. [Delegator] Hold delegate references in Python instead of C++

    This prevents the creation of circular references that aren't
    traversable by the Python garbage collector and therefore can never be
    reclaimed.
    speth committed Dec 31, 2021
    Configuration menu
    Copy the full SHA
    3e5e10b View commit details
    Browse the repository at this point in the history
  46. Configuration menu
    Copy the full SHA
    aaf6d57 View commit details
    Browse the repository at this point in the history
  47. Configuration menu
    Copy the full SHA
    c997235 View commit details
    Browse the repository at this point in the history
  48. Configuration menu
    Copy the full SHA
    942f7af View commit details
    Browse the repository at this point in the history
  49. Configuration menu
    Copy the full SHA
    3d813ed View commit details
    Browse the repository at this point in the history