Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AnyValue test failures with old Boost versions #1123

Merged
merged 1 commit into from
Oct 19, 2021

Conversation

speth
Copy link
Member

@speth speth commented Oct 19, 2021

Without Boost, the string versions of certain typenames are compiler-dependent.

Changes proposed in this pull request

  • Make sure we use consistent names for all of the types where we end up checking for the names in the test suite.
  • correct comment indicating the minimum version of Boost that has the demangle function.

If applicable, fill in the issue number this pull request is fixing

Fixes #1040

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

Without Boost, the string versions of certain typenames are
compiler-dependent. Make sure we use consistent names for all of the
types where we end up checking for the names in the test suite.

Also, correct comment indicating the minimum version of Boost that has
the demangle function.

Fixes Cantera#1040
@codecov
Copy link

codecov bot commented Oct 19, 2021

Codecov Report

Merging #1123 (5559070) into main (a84b6e6) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1123      +/-   ##
==========================================
- Coverage   73.45%   73.45%   -0.01%     
==========================================
  Files         364      364              
  Lines       47884    47884              
==========================================
- Hits        35172    35171       -1     
- Misses      12712    12713       +1     
Impacted Files Coverage Δ
src/base/AnyMap.cpp 89.51% <ø> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a84b6e6...5559070. Read the comment docs.

Copy link
Member

@ischoegl ischoegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (per rationale in commit comment).

@ischoegl ischoegl merged commit 6b231b1 into Cantera:main Oct 19, 2021
@speth speth deleted the fix-1040 branch July 23, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure in test-python-utils with v2.6.0a2
2 participants