Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation updates #1231

Merged
merged 6 commits into from
Mar 28, 2022
Merged

Documentation updates #1231

merged 6 commits into from
Mar 28, 2022

Conversation

speth
Copy link
Member

@speth speth commented Mar 27, 2022

Changes proposed in this pull request

  • Add YAML API docs for two-temperature-plasma reaction
  • Fix links in TwoTempPlasmaRate constructor
  • Provide extended description of derivative_speed.cpp for website
  • Clarify rationale for ArrheniusRateBase._cinit
  • Describe list-based format for YAML coverage dependencies
  • dusty_gas.py requires Cantera 2.6.0

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #1231 (d5ee2af) into main (cd98c25) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1231      +/-   ##
==========================================
- Coverage   65.47%   65.47%   -0.01%     
==========================================
  Files         327      327              
  Lines       46349    46350       +1     
  Branches    19688    19688              
==========================================
  Hits        30349    30349              
- Misses      13475    13476       +1     
  Partials     2525     2525              
Impacted Files Coverage Δ
src/base/AnyMap.cpp 85.12% <0.00%> (-0.08%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Member

@ischoegl ischoegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (and PR failures are caused by other issues).

@speth speth merged commit 04142f6 into Cantera:main Mar 28, 2022
@speth speth deleted the fix-docs branch March 28, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants