Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite Jupyter Notebook examples as Python examples #1681

Merged
merged 18 commits into from
Apr 20, 2024

Conversation

speth
Copy link
Member

@speth speth commented Mar 27, 2024

Changes proposed in this pull request

For all the examples that included diagrams, I re-drew the PNGs in Adobe Illustrator and saved them as SVGs, to avoid having to commit these moderately large binary files into the repo, and because the vector versions just look nicer.

I've added co-author credit in the commit message for the original authors of the Jupyter examples.

Note that this already incorporates the fix to the 1D packed bed example from Cantera/cantera-jupyter#47.

If applicable, fill in the issue number this pull request is fixing

If applicable, provide an example illustrating new features this pull request is introducing

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

Copy link
Member

@ischoegl ischoegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm 👍 with removing ck2yaml_demo.ipynb, even though I had created it to document how the input files were created in the first place. Perhaps we can preserve some of this history with some annotations in the yaml files we distribute? At the same time, I don't have strong opinions either way.

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.69%. Comparing base (0c89553) to head (923af6f).
Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1681      +/-   ##
==========================================
+ Coverage   72.76%   75.69%   +2.93%     
==========================================
  Files         378      443      +65     
  Lines       56986    60975    +3989     
  Branches    20691     9551   -11140     
==========================================
+ Hits        41468    46158    +4690     
+ Misses      12463    11786     -677     
+ Partials     3055     3031      -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

speth and others added 9 commits April 17, 2024 22:00
Co-authored-by: Gandhali Kogekar <gkogekar@gmail.com>
Co-authored-by: Bryan W. Weber <bryan.w.weber@gmail.com>
Co-authored-by: Steven DeCaluwe <steven.decaluwe@gmail.com>
Co-authored-by: Santosh Shanbhogue <santosh.shanbhogue@gmail.com>
Co-authored-by: Richard West <r.west@northeastern.edu>
Re-draw figure from Jupyter example as an SVG.

Co-authored-by: Santosh Shanbhogue <santosh.shanbhogue@gmail.com>
@speth speth force-pushed the jupyter2gallery branch 9 times, most recently from 71452e5 to 0d75520 Compare April 18, 2024 22:57
speth and others added 5 commits April 18, 2024 21:21
Co-authored-by: Gandhali Kogekar <gkogekar@gmail.com>
Brings in some updates based on nonideal_shock_tube.ipynb and
batch_reactor_ignition_delay_NTC.ipynb.

Co-authored-by: Santosh Shanbhogue <santosh.shanbhogue@gmail.com>
Co-authored-by: Steven DeCaluwe <steven.decaluwe@gmail.com>
Co-authored-by: Sai Krishna <sirumalla.s@husky.neu.edu>
Co-authored-by: Santosh Shanbhogue <santosh.shanbhogue@gmail.com>
Copy link
Member

@ischoegl ischoegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this, @speth. Merging the notebooks back into samples is greatly appreciated!

@ischoegl ischoegl merged commit d37a76b into Cantera:main Apr 20, 2024
51 checks passed
@speth speth deleted the jupyter2gallery branch July 23, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants