Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Move extra.yaml to the correct directory #813

Merged
merged 1 commit into from
Feb 21, 2020

Conversation

speth
Copy link
Member

@speth speth commented Feb 21, 2020

The interfaces/cython/cantera/test/data directory is just a copy of the test/data directory, created as part of the build process.

Checklist

  • There is a clear use-case for this code change
  • The commit message has a short title & references relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • The pull request is ready for review

Changes proposed in this pull request

  • Move extra.yaml to test/data

The interfaces/cython/cantera/test/data directory is just a copy of
test/data, created as part of the build process.
@speth speth added bug tests Issues about tests, running the tests, or test results labels Feb 21, 2020
@codecov
Copy link

codecov bot commented Feb 21, 2020

Codecov Report

Merging #813 into master will decrease coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #813      +/-   ##
==========================================
- Coverage   71.57%   71.39%   -0.18%     
==========================================
  Files         372      372              
  Lines       44376    43482     -894     
==========================================
- Hits        31760    31045     -715     
+ Misses      12616    12437     -179     
Impacted Files Coverage Δ
include/cantera/thermo/PDSS.h 0.00% <0.00%> (-100.00%) ⬇️
include/cantera/equil/vcs_MultiPhaseEquil.h 0.00% <0.00%> (-100.00%) ⬇️
include/cantera/equil/MultiPhaseEquil.h 0.00% <0.00%> (-95.00%) ⬇️
include/cantera/thermo/MolalityVPSSTP.h 20.00% <0.00%> (-80.00%) ⬇️
include/cantera/transport/GasTransport.h 20.00% <0.00%> (-80.00%) ⬇️
include/cantera/thermo/SpeciesThermoInterpType.h 20.00% <0.00%> (-70.00%) ⬇️
include/cantera/base/global.h 38.46% <0.00%> (-54.88%) ⬇️
include/cantera/thermo/VPStandardStateTP.h 20.00% <0.00%> (-51.43%) ⬇️
include/cantera/thermo/Phase.h 50.00% <0.00%> (-36.05%) ⬇️
src/clib/Cabinet.h 0.00% <0.00%> (-26.42%) ⬇️
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6b2e6e...d0cbab5. Read the comment docs.

@speth speth merged commit 97c96a0 into Cantera:master Feb 21, 2020
@speth speth deleted the fix-extrayaml branch July 23, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug tests Issues about tests, running the tests, or test results
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants