Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cantera version and commit to HDF output #860

Merged
merged 1 commit into from
Jun 8, 2020

Conversation

ischoegl
Copy link
Member

@ischoegl ischoegl commented Jun 6, 2020

Checklist

  • There is a clear use-case for this code change
  • The commit message has a short title & references relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • The pull request is ready for review

Changes proposed in this pull request

Minor addendum to #840 ... when retrieving old simulation data, it may be of interest to identify the cantera version used for its generation.

  • Add Cantera version to HDF output

@codecov
Copy link

codecov bot commented Jun 6, 2020

Codecov Report

Merging #860 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #860   +/-   ##
=======================================
  Coverage   71.57%   71.57%           
=======================================
  Files         372      372           
  Lines       44501    44501           
=======================================
  Hits        31851    31851           
  Misses      12650    12650           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e3b6d0...294bfd0. Read the comment docs.

@ischoegl
Copy link
Member Author

ischoegl commented Jun 6, 2020

@speth ... this should be inconsequential (while addressing something I hadn’t thought of until looking at data I generated back in 2012); I’m wondering whether to include the sundials version also (although I don’t think it’s necessary).

PS: Sorry for not catching this earlier, I honestly thought I had everything covered.

@ischoegl
Copy link
Member Author

ischoegl commented Jun 7, 2020

As an aside, I think some of the 1D Project Ideas can be closed, as they’re taken care of.

@speth
Copy link
Member

speth commented Jun 8, 2020

The Sundials version is not relevant, since it is not used by the 1D solver.

@speth speth merged commit 4b9adfa into Cantera:master Jun 8, 2020
@ischoegl ischoegl deleted the add-cantera-version-to-hdf branch July 13, 2020 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants