-
-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Miscellaneous build system improvements, and mark release of Cantera 2.5.0 #974
Conversation
Handle the same special cases that we take care of for the full Python module. Fixes Cantera#969
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @speth! I have a few questions/comments:
- I don't understand the commit message on e590fb6. I don't see how that change will affect only the minimal interface. Can you clarify the commit message?
- I checked the conversion scripts to make sure any changes since
a3
would not change the output. I found thatair.cti
had a little bit of reduced precision compared togri30_tran.dat
, meaning that there's an extra digit of precision in the newair.yaml
compared toair.cti
. I doubt this will affect anyone's results too much, but we probably want to note it in the release notes somewhere. - The
ohmech.cti
file has the phaseohmech-multi
, which should be added toohmech.yaml
and deprecated, like we did forgri30.yaml
.
Otherwise, I think these changes look good!
e590fb6 only affects the minimal Python module because it's editing |
🤦♂️ Dangit! Thank you for pointing that out. |
Regarding (2), the issue with transport coefficient precision dates from the old C++ version of |
Matches the definition in h2o2.cti. Like what we are doing with the gri30.cti -> gri30.yaml transition, this phase name is immediately deprecated.
Update 'cantera-version' in all YAML files to correspond to the stable release.
@bryanwweber, I added commit fb98298 which I think takes care of (3). |
Woo! Feel free to merge + tag when the CI finishes. |
Most of these changes address issues I ran into while trying to build the Ubuntu package. A couple are related to issues identified while investigating #969.
Changes proposed in this pull request
python3
sudo
when runningscons install
(per discussion on Compiling Cantera from source fails to find numpy and cython in conda environment #963)If applicable, fill in the issue number this pull request is fixing
Fixes #969
Checklist
scons build
&scons test
) and unit tests address code coverage