-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure provider #493
Azure provider #493
Conversation
@@ -3,6 +3,9 @@ | |||
# Util functions cloud reusable. | |||
APOLLO_ROOT=$(dirname "${BASH_SOURCE}")/.. | |||
DEFAULT_CONFIG="${APOLLO_ROOT}/bootstrap/${APOLLO_PROVIDER}/${APOLLO_CONFIG_FILE-"config-default.sh"}" | |||
# It must be change before mergeing with capgemini master branch | |||
DYNAMIC_INVENTORY="https://raw.githubusercontent.com/ravbaba/terraform.py/azure-provider/terraform.py" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The url should be change back to https://raw.githubusercontent.com/Capgemini/terraform.py/master/terraform.py after merging my PR to capgemini terraform.py repo
adf7315
to
94c27bb
Compare
Is this overlapping with #320 ? |
public_port = 8500 | ||
private_port = 8500 | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might need some more endpoints for consul here as these are the ports that consul uses
Client Addr: 127.0.0.1 (HTTP: 8500, DNS: 8600, RPC: 8400)
Cluster Addr: 192.168.1.43 (LAN: 8301, WAN: 8302)
What's the current state of this? still WIP? I haven't made an Azure deployment but code looks pretty good to me. |
I am gonna create a new PR with a different approach. Because I encountered some difficulties using terraform with azure so I decided to do it with Azure Resource Manager template using azure cli. I am going to build an inventory file base on the example. https://github.com/ansible/ansible/blob/devel/contrib/inventory/windows_azure.py Anyway we should keep the PR just in case if terraform will have better support for Azure. At the moment there are not support for ARM. |
Setting this PR to blocked for now then. |
location = "${var.region}" | ||
} | ||
|
||
resource "azure_security_group_rule" "all-inbound" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to be some special constants described here - https://azure.microsoft.com/en-us/documentation/articles/virtual-networks-nsg/ such as INTERNET / VIRTUAL_NETWORK - might be worth double checking the docs
Removing blocked label - we have a way forward with hashicorp/terraform#3695 |
b859fbc
to
75d3162
Compare
efe404a
to
a5216b5
Compare
@@ -0,0 +1 @@ | |||
ssh -t "ubuntu@$(terraform output bastion.ip)" sudo docker run --volumes-from ovpn-data --rm gosuri/openvpn ovpn_getclient "${1}" > "${1}-apollo.ovpn" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can move the ovpn scripts into folder terraform/bin or something like that because we repeat it here.
e4ebd7d
to
44e6e04
Compare
229db03
to
b92ad62
Compare
b92ad62
to
eea66cd
Compare
Still need more work