Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "fire_bullets" event from erroring. #1350

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Fix "fire_bullets" event from erroring. #1350

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fa345ca
Fix "fire_bullets" event from erroring.
unknao Apr 18, 2024
28b7b5d
remove the local
unknao Apr 19, 2024
7657713
undelete the hide bullets return
pingu7867 Jun 5, 2024
0f9b73f
fire bullets singleplayer hack fix
pingu7867 Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions lua/pac3/core/client/parts/event.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1462,7 +1462,7 @@ PART.OldEvents = {
operator_type = "string", preferred_operator = "find simple",
tutorial_explanation = "fire_bullets supposedly checks what types of bullets you're firing",
arguments = {{find_ammo = "string"}, {time = "number"}},
callback = function(self, ent, find, time)
callback = function(self, ent, find_ammo, time)
time = time or 0.1

ent = try_viewmodel(ent)
Expand Down Expand Up @@ -3382,10 +3382,6 @@ pac.AddHook("EntityFireBullets", "firebullets", function(ent, data)
ent.pac_fire_bullets = {name = data.AmmoType, time = pac.RealTime, reset = true}

pac.CallRecursiveOnAllParts("OnFireBullets")

if ent.pac_hide_bullets then
return false
end
Comment on lines -3385 to -3388
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idk if removing this is right. Someone else verify

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first glance, if we search "pac_hide_bullets", it seemed as though the field isn't created anywhere (so, accessing it would always be nil if that was the case)
But, if we run the search without the pac_ prefix, it leads to EntityField functions, the builder thing that set an entity field with that prefix.
(for OP's information) This one wasn't obvious, that prefix business is just a thing that we do a few times throughout the code.

We still want that return because we still want the option to hide the bullets.

But there's some side issues in singleplayer. I tried to test, it appears the EntityFireBullets hook is ineffective. But it's fine with local server and p2p setups for some reason... oh well!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@unknao can you revert this change?

end)

--for regaining focus on cameras from first person, hacky thing to not loop through localparts every time
Expand Down
Loading