A0-2583: Prevent reaching max round too fast #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
round takes large enough amount of time. The function is not called in AlephBFT as various projects which use aleph-bft may expect different delays. Instead the function is publically exposed to be called in the project which uses AlephBFT.
|
Please make sure the following happened
|
woocash2
changed the title
DamianStraszak
requested changes
Jun 12, 2023
* Fields of Config changed to pub(crate) so they are private in perspective of the user outside of the crate * The only way to create a Config from the outside is to use create_config function * create_config takes optional max_round and delay_config which have default values * argument time_to_reach_max_round has to be passed to create_config and it is used to perform the check * the check always happens when create_config is called. Adjusted other crates in AlephBFT which use Config
timorl
suggested changes
Jun 14, 2023
timorl
approved these changes
Jun 26, 2023
woocash2
requested review from
DamianStraszak
and removed request for
DamianStraszak
DamianStraszak
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a function which can be used to check whether reaching the maximum round takes large enough amount of time. The function is not called in AlephBFT as various projects which use aleph-bft may expect different delays. Instead the function is publically exposed to be called in the project which uses AlephBFT.
Tests:
orderingandblockchainexamples work wellaleph-node(after needed changes) works with this version of AlephBFT (but turned out we also need to makedefault_delay_configpublic)