Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A0-4152: Global consensus threshold and other crypto improvements #423

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

timorleph
Copy link
Contributor

Small, seemingly disjointed changes to the crypto API and some resulting changes in the consensus unit tests. They were easy to split off of the bigger refactor so I did that to make that one smaller and make it clearer what the version changes entail.

Copy link

Please make sure the following happened

  • Appropriate tests created
  • Infrastructure updated accordingly
  • Updated existing documentation
  • New documentation created
  • Version bumped if breaking changes

@timorleph timorleph requested review from lesniak43, ggawryal and kostekIV and removed request for ggawryal March 11, 2024 12:55
Copy link
Contributor

@kostekIV kostekIV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about:

  • function quorum in mock/src/crypto/keychain.rs
  • function quorum in crypto/src/signature.rs
  • in crashed_nodes_recover fn on line 168 in fule consensus/src/testing/crash_recovery.rs you can also use consensus_threshold function

consensus/src/creation/creator.rs Outdated Show resolved Hide resolved
@timorleph timorleph merged commit a48614e into Cardinal-Cryptography:main Mar 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants