A0-1672: units returned by run_session #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please make sure the following happened
|
fixxxedpoint
force-pushed
the
A0-1672_abft-performance-PR
branch
2 times, most recently
from
f67f02f
to
2b09eeb
Compare
timorleph
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
Cool changes, although I have some comments.
Also cc @joschisan – as you can see we are actually implementing the more advanced interface after all, so feel free to comment here.
lesniak43
approved these changes
Apr 22, 2024
fixxxedpoint
force-pushed
the
A0-1672_abft-performance-PR
branch
4 times, most recently
from
4851fad
to
c83c1ae
Compare
timorleph
reviewed
Apr 24, 2024
timorleph
reviewed
Apr 24, 2024
fixxxedpoint
force-pushed
the
A0-1672_abft-performance-PR
branch
from
890d9cb
to
f52f918
Compare
… Data - added OrderedUnit: unit api for the UnitFinalizationHandler
… which is parametrized enough for calling it with batches of units
…ion for FinalizationHandler<BatchOfUnits>
…individual fields
timorleph
reviewed
Apr 29, 2024
…deredUnit::parents
fixxxedpoint
force-pushed
the
A0-1672_abft-performance-PR
branch
from
f52f918
to
19a0d03
Compare
…ndler - using an adapter type instead - Data and Hasher are not associated types of UnitFinalizationHandler
|
@timorleph the advanced interface works for us just as well as far as I can tell. |
…ler's associated types (Data, Hasher)
fixxxedpoint
force-pushed
the
A0-1672_abft-performance-PR
branch
from
b11baab
to
06e9f67
Compare
timorleph
approved these changes
May 3, 2024
…ead of seperatly providing Data and Hasher
timorleph
reviewed
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A separate method in member
run_session_for_unitsthat allows one to track finalization of batches of units.