Add example smart contracts with comprehensive README. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rusfmt and rust-toolchain files live in individual contracts folders now.
Marcin-Radecki
approved these changes
Nov 2, 2022
Co-authored-by: Michal Handzlik <h4nsu@users.noreply.github.com>
h4nsu
approved these changes
Nov 7, 2022
fbielejec
reviewed
Nov 7, 2022
fbielejec
reviewed
Nov 7, 2022
fbielejec
reviewed
Nov 7, 2022
fbielejec
reviewed
Nov 7, 2022
fbielejec
reviewed
Nov 7, 2022
fbielejec
reviewed
Nov 7, 2022
fbielejec
reviewed
Nov 7, 2022
| // simpler for the caller to handle an error - in contract to | ||
| // `panic!` that doesn't contain any additional | ||
| // information and is simply `CalleeTrapped`. | ||
| if transferred_amount < listing_cost { |
There was a problem hiding this comment.
Will the caller be reimbursed with transferred amount here?
There was a problem hiding this comment.
if my understanding is correct then yes -- returning Err is equivalent to panic! w.r.t. to contract's state reversal. I can add a test for that though.
There was a problem hiding this comment.
i'd expect that too, but whatever amount is sent with the tx uses the balances pallet (not contracts state from the pallet contracts). But it'd actually be a bug if it wasn't
fbielejec
reviewed
Nov 7, 2022
Co-authored-by: Michal Handzlik <h4nsu@users.noreply.github.com> Co-authored-by: Filip Bielejec <fbielejec@gmail.com>
fbielejec
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two simple smart contracts showcasing all the basic building blocks of writing smart contracts, including:
The
README.mditself contains short descriptions of all techniques used when writing the contracts. There's also a description about deploying it to Contracts UI.What will follow will be a simple frontend that interacts with the deployed contracts showing how to publish transaction to a chain (signing it with polkadotjs app extension), how to await finalization, read the results, etc.