Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Support for Apple Silicon (arm64) Macs #158

Merged
merged 5 commits into from
Feb 10, 2021
Merged

✨ Support for Apple Silicon (arm64) Macs #158

merged 5 commits into from
Feb 10, 2021

Conversation

chris-araman
Copy link
Contributor

Updating dependencies to pick up support for Apple Silicon (arm64).

Relevant PRs:
Quick/Nimble#827
xcconfigs/xcconfigs#98

This will aid in enabling arm64 support for mas-cli/mas#308.

FYI @phatblat @fabriceb

@chris-araman chris-araman changed the title ⬆️ xcconfigs (1.1), Quick (3.0.0), Nimble (9.0.0) ✨ Support for Apple Silicon (arm64) Jan 21, 2021
Comment on lines -44 to -46
name: Xcode 10.2 / Swift 5.0
osx_image: xcode10.2
env: JOB=Xcode10.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this PR drop support for Swift 5.0 and/or Xcode 10.2's sdk? If so, that's probably something we should be cautious about.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I believe it would drop support for Swift 5.0 because Quick 3.0.0 and Nimble 9.0.0 require Swift 5.2 and Xcode 11.4.

Alternatively, we could urge the maintainers of Quick and Nimble to port Apple Silicon support back to Quick 2.x and Nimble 8.x.

Incidentally, I think we'll still need to wait for a subsequent release of Quick, as Quick/Quick@1172a5d wasn't in the 3.0.0 release.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ikesyo I would love to hear your quick thoughts about these Swift version changes as you've been handling that well for several of the mentioned projects.

@chris-araman chris-araman changed the title ✨ Support for Apple Silicon (arm64) ✨ [WIP] Support for Apple Silicon (arm64) Jan 21, 2021
@chris-araman chris-araman changed the title ✨ [WIP] Support for Apple Silicon (arm64) ✨ [WIP] Support for Apple Silicon (arm64) Macs Jan 21, 2021
@fabriceb
Copy link

Thanks for that @chris-araman !

@rgoldberg
Copy link

rgoldberg commented Jan 28, 2021

Must anything else be done before this can be merged?

@chris-araman
Copy link
Contributor Author

I think we still need Quick 3.0.1 to be released with Quick/Quick@1172a5d from @ikesyo.

@rgoldberg
Copy link

rgoldberg commented Jan 28, 2021

That commit was merged into master 4 months ago.

Why would they wait so long to release something that makes their software work natively on Apple Silicon?

chris-araman referenced this pull request in Quick/Quick Feb 3, 2021
Removed VALID_ARCHS from the macOS Target.

Co-authored-by: mRs- <marius@deepl.com>
@chris-araman chris-araman changed the title ✨ [WIP] Support for Apple Silicon (arm64) Macs ✨ Support for Apple Silicon (arm64) Macs Feb 5, 2021
@chris-araman
Copy link
Contributor Author

chris-araman commented Feb 5, 2021

I've updated to Quick 3.0.1, but the arm64 fix was not yet included in this release. @ikesyo, what is preventing this change from being released?
Quick/Quick@1172a5d

@chris-araman chris-araman changed the title ✨ Support for Apple Silicon (arm64) Macs ✨ [WIP] Support for Apple Silicon (arm64) Macs Feb 5, 2021
@chris-araman chris-araman changed the title ✨ [WIP] Support for Apple Silicon (arm64) Macs ✨ Support for Apple Silicon (arm64) Macs Feb 5, 2021
@chris-araman
Copy link
Contributor Author

chris-araman commented Feb 5, 2021

I've picked up @ikesyo's fix for arm64 with Quick 3.1.0. (Thanks, @ikesyo!)

@elliottwilliams, @ikesyo, @phatblat, this is now ready for review and release.

@elliottwilliams elliottwilliams self-requested a review February 5, 2021 22:55
Copy link
Member

@phatblat phatblat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chris-araman!

@phatblat phatblat merged commit 775d687 into Carthage:master Feb 10, 2021
@phatblat phatblat mentioned this pull request Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants