-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Support for Apple Silicon (arm64) Macs #158
Conversation
name: Xcode 10.2 / Swift 5.0 | ||
osx_image: xcode10.2 | ||
env: JOB=Xcode10.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this PR drop support for Swift 5.0 and/or Xcode 10.2's sdk? If so, that's probably something we should be cautious about.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I believe it would drop support for Swift 5.0 because Quick 3.0.0 and Nimble 9.0.0 require Swift 5.2 and Xcode 11.4.
Alternatively, we could urge the maintainers of Quick and Nimble to port Apple Silicon support back to Quick 2.x and Nimble 8.x.
Incidentally, I think we'll still need to wait for a subsequent release of Quick, as Quick/Quick@1172a5d wasn't in the 3.0.0 release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ikesyo I would love to hear your quick thoughts about these Swift version changes as you've been handling that well for several of the mentioned projects.
Thanks for that @chris-araman ! |
Must anything else be done before this can be merged? |
I think we still need Quick 3.0.1 to be released with Quick/Quick@1172a5d from @ikesyo. |
That commit was merged into master 4 months ago. Why would they wait so long to release something that makes their software work natively on Apple Silicon? |
Removed VALID_ARCHS from the macOS Target. Co-authored-by: mRs- <marius@deepl.com>
I've updated to Quick 3.0.1, but the arm64 fix was not yet included in this release. @ikesyo, what is preventing this change from being released? |
I've picked up @ikesyo's fix for arm64 with Quick 3.1.0. (Thanks, @ikesyo!) @elliottwilliams, @ikesyo, @phatblat, this is now ready for review and release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @chris-araman!
Updating dependencies to pick up support for Apple Silicon (arm64).
Relevant PRs:
Quick/Nimble#827
xcconfigs/xcconfigs#98
This will aid in enabling arm64 support for mas-cli/mas#308.
FYI @phatblat @fabriceb