Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PG12 compatibility #104

Merged
merged 3 commits into from
Oct 21, 2019
Merged

PG12 compatibility #104

merged 3 commits into from
Oct 21, 2019

Conversation

Algunenano
Copy link

Untested. Needs CI fixed first and then integrate PG12 in Travis. Fixes #103

@mlt
Copy link

mlt commented Oct 16, 2019

It could be shorter b08830b . I can use yours instead and test on Windows with AppVeyor CI.

@Algunenano
Copy link
Author

The problem with keeping heap_open is that it is highly likely to disappear in PG13, so I'd rather fix it once and for all. In any case, now that I look at it again I don't like having multiple #ifdefs in the code itself so I think I'll move it into a macro in the top of the file. I'll certainly revisit this once the CI is working again.

@Algunenano
PG12: Use table_close
c3ccdbf 
heap_close was moved in PG12 and will disappear with PG13
@Algunenano
Try to add PG12 to travis
9431bd2
@Algunenano Algunenano merged commit e4d5fe8 into master Oct 21, 2019
@thomas-maschler thomas-maschler mentioned this pull request Oct 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Doesn't compile against PostgreSQL 12
2 participants
@Algunenano @mlt