Fix columns iteration #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafatower
approved these changes
Sep 7, 2020
| if (SQL_SUCCEEDED(diag_ret)) | ||
| elog(DEBUG1, "FETCHING %s:%ld:%ld:%s\n", state, (long int) j, (long int) native, text); | ||
| } | ||
| while( diag_ret == SQL_SUCCESS ); |
There was a problem hiding this comment.
from my ignorance: don't you want to log anything when ret == SQL_ERROR ? or is that covered by the diag_ret ?
There was a problem hiding this comment.
Note that diag_ret is the result of calling GetDescRec to get diagnostic messages iteratively (there may be multiple messages). According to documentation SQL_NO_DATA should signal the end of the iteration, but I'm stopping at anything other than SQL_SUCCESS to avoid handling errors here 🙈 (hopefully unlikely)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had cases of empty column lists in some cases with the ODBC drivers for BigQuery and Snowflake.
After some debugging with the latter, it seems that column iteration may be interrupted by
SQLFetcherros responses like these:With this patch those errors are ignored (skipping columns of unsupported types) and the iteration is resumed.