Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

Pinned Labelbase submodule to tag 2.2.0 #6

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Pinned Labelbase submodule to tag 2.2.0 #6

merged 1 commit into from
Jun 3, 2024

Conversation

xavierfiechter
Copy link
Contributor

Thank you for making Labelbase available on Start9.
Labelbase 2.2.0 was just released. I have updated the submodule with the corresponding tag.

@storopoli
Copy link
Member

Thanks. I am still having some issues with repurposing the docker-compose.yml file to a single Dockerfile. That's how start9 works.
If you are able to check

https://github.com/CasaVinteUm/labelbase-startos/blob/0d538cd91da088289ad782ee5e4416e2298e341e/Dockerfile

that would be awesome.

@storopoli storopoli merged commit 44f1711 into CasaVinteUm:master Jun 3, 2024
1 check failed
@xavierfiechter
Copy link
Contributor Author

Does it work as is?

Would it be simpler and more robust to run a shell script instead?

I'm currently working on the Raspiblitz integration, see here https://github.com/xavierfiechter/raspiblitz/blob/master/home.admin/config.scripts/bonus.labelbase.sh

@storopoli
Copy link
Member

start-os is really Docker-centric.
I think it would be best (and easiest) to create a single Dockerfile (multi-stage build) from the Docker-Compose file.

@xavierfiechter
Copy link
Contributor Author

Okay, but does labelbase-startos work as it is right now?

Sorry, I don't have a test device at hand at the moment.

@storopoli
Copy link
Member

No it doesn't. I've merged #4 since it is 99% of the way.
You don't need start-os to test it. If you are able to make the Dockerfile work, in other words, if you do docker run and it runs labelbase successfully, then it will be very trivial for me to finish the packaging for start-os.

@storopoli
Copy link
Member

The problem is not packaging it to start-os, but to convert the docker compose to a single dockerfile.
That dockerfile is consumed by start-os SDK to create the app.

@xavierfiechter
Copy link
Contributor Author

Got it.

ENV MYSQL_USER=ulabelbase
ENV MYSQL_DATABASE=labelbase
ENV MYSQL_ROOT_PASSWORD=labelbase
ENV MYSQL_PASSWORD=labelbase
ENV MYSQL_PWD=labelbase

I don't particularly like that approach, yet many Dockerfiles include hard-coded passwords. That's why I implemented it using the Twelve-Factor App methodology, which resulted in an exports.sh file.

But hey, let's get this up and running. I'll check the Dockerfile as soon as possible.

@storopoli
Copy link
Member

storopoli commented Jun 3, 2024

Yes that will change 😓 it will not be hardcoded.
The ideia is to expose that in the start-os GUI for the user to configure.
This is an example from the syncthing start-os package:

https://github.com/Start9Labs/syncthing-startos/blob/724b613c5e880e7476c93afd022d249f62a4b8d0/scripts/procedures/getConfig.ts#L3-L36

Edit: tracking on #7.

@storopoli storopoli mentioned this pull request Jun 3, 2024
@xavierfiechter
Copy link
Contributor Author

Awesome!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants