rework a bunch of the *tructible concepts, Movable requires object types #66
Conversation
| @@ -27,7 +27,7 @@ STL2_OPEN_NAMESPACE { | |||
| concept bool _Is = _Valid<T, U, V...> && T<U, V...>::value; | |||
|
|
|||
| template <class U, template <class...> class T, class...V> | |||
| concept bool _IsNot = !_Is<U, T, V...>; | |||
| concept bool _IsNot = _Valid<T, U, V...> && !T<U, V...>::value; | |||
|
|
||
| template <class T, class U> | ||
| concept bool Assignable() { | ||
| return CommonReference<const T&, const U&>() && | ||
| return Same<T, decay_t<T>&>() && | ||
| CommonReference<const T&, const U&>() && |
There was a problem hiding this comment.
Given that T is an lvalue reference type, const T& is the same type as T.
| @@ -25,6 +25,10 @@ STL2_OPEN_NAMESPACE { | |||
| template <class> | |||
| constexpr bool __addressable = false; | |||
| template <class T> | |||
| constexpr bool __addressable<T&> = true; | |||
| template <class T> | |||
| constexpr bool __addressable<T&&> = true; | |||
There was a problem hiding this comment.
This is right for Destructible, but wrong for Addressable: Addressable needs to be changed to _Is<T, is_object> && __addressable<T>. Destructible need not subsume Addressable, we can define it as:
namespace models {
template <class T>
constexpr bool Destructible = std::is_nothrow_destructible<T>::value && __addressable<T>;
}
template <class T>
concept bool Destructible() { return models::Destructible<T>; }There was a problem hiding this comment.
That definition of Destructible changes the result from true to false for reference types. We don't want that.
There was a problem hiding this comment.
Oh, I misunderstood. You mean to leave the reference type specializations in for __addressable. Got it.
ericniebler
force-pushed
the
constructible
branch
2 times, most recently
from
c946f3e to
a266238
Compare
CaseyCarter
force-pushed
the
constructible
branch
from
a266238 to
8520289
Compare
...and ericniebler/stl2#313. |
|
...and ericniebler/stl2#300. |
|
...and caseycarter/stl2#22. |
Fixing a bunch of open issues with the low-level object concepts; namely, ericniebler/stl2#301, ericniebler/stl2#310, ericniebler/stl2#229, and ericniebler/stl2#70.