[flutter_plugin_android_lifecycle] Fix lints (flutter#4030)

Removes lint-baseline.xml and fixes the resulting warnings. Part of flutter#88011
CaseyHillers · May 18, 2023 · b31a128 · b31a128
1 parent 70eb807
commit b31a128
Show file tree

Hide file tree

Showing 6 changed files with 5 additions and 22 deletions.
diff --git a/packages/flutter_plugin_android_lifecycle/CHANGELOG.md b/packages/flutter_plugin_android_lifecycle/CHANGELOG.md
@@ -1,5 +1,6 @@
-## NEXT
+## 2.0.15
 
+* Fixes Java lints.
 * Updates minimum supported SDK version to Flutter 3.3/Dart 2.18.
 
 ## 2.0.14

diff --git a/packages/flutter_plugin_android_lifecycle/android/build.gradle b/packages/flutter_plugin_android_lifecycle/android/build.gradle
@@ -43,7 +43,6 @@ android {
         checkAllWarnings true
         warningsAsErrors true
         disable 'AndroidGradlePluginVersion', 'InvalidPackage', 'GradleDependency'
-        baseline file("lint-baseline.xml")
     }
 
     dependencies {
@@ -68,4 +67,3 @@ dependencies {
     testImplementation 'junit:junit:4.13.2'
     testImplementation 'org.mockito:mockito-core:5.1.1'
 }
-
diff --git a/packages/flutter_plugin_android_lifecycle/android/lint-baseline.xml b/packages/flutter_plugin_android_lifecycle/android/lint-baseline.xml
diff --git a/.../src/main/java/io/flutter/embedding/engine/plugins/lifecycle/FlutterLifecycleAdapter.java b/.../src/main/java/io/flutter/embedding/engine/plugins/lifecycle/FlutterLifecycleAdapter.java
@@ -10,8 +10,6 @@
 
 /** Provides a static method for extracting lifecycle objects from Flutter plugin bindings. */
 public class FlutterLifecycleAdapter {
-  private static final String TAG = "FlutterLifecycleAdapter";
-
   /**
    * Returns the lifecycle object for the activity a plugin is bound to.
    *

diff --git a/...va/io/flutter/plugins/flutter_plugin_android_lifecycle/FlutterAndroidLifecyclePlugin.java b/...va/io/flutter/plugins/flutter_plugin_android_lifecycle/FlutterAndroidLifecyclePlugin.java
@@ -15,7 +15,8 @@
  */
 public class FlutterAndroidLifecyclePlugin implements FlutterPlugin {
   @SuppressWarnings("deprecation")
-  public static void registerWith(io.flutter.plugin.common.PluginRegistry.Registrar registrar) {
+  public static void registerWith(
+      @NonNull io.flutter.plugin.common.PluginRegistry.Registrar registrar) {
     // no-op
   }
 

diff --git a/packages/flutter_plugin_android_lifecycle/pubspec.yaml b/packages/flutter_plugin_android_lifecycle/pubspec.yaml
@@ -2,7 +2,7 @@ name: flutter_plugin_android_lifecycle
 description: Flutter plugin for accessing an Android Lifecycle within other plugins.
 repository: https://github.com/flutter/packages/tree/main/packages/flutter_plugin_android_lifecycle
 issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+flutter_plugin_android_lifecycle%22
-version: 2.0.14
+version: 2.0.15
 
 environment:
   sdk: ">=2.18.0 <4.0.0"