Refactor to allow updating a loyalty card from a bundle #2051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheLastProject
commented
Aug 20, 2024
app/src/main/java/protect/card_locker/LoyaltyCardEditActivity.java
Outdated
Show resolved
Hide resolved
app/src/main/java/protect/card_locker/LoyaltyCardEditActivity.java
Outdated
Show resolved
Hide resolved
TheLastProject
force-pushed
the
refactor/updateLoyaltyCardFromBundle
branch
2 times, most recently
from
0ec034e
to
4ca7f71
Compare
|
Hilarious, all the tests are broken because apparently the edit activity was such a mess it kept chugging along even if there was no loyalty card and cleaning that up caused all these tests to fail as they made use of that bug... |
TheLastProject
force-pushed
the
refactor/updateLoyaltyCardFromBundle
branch
from
4ca7f71
to
5feb68b
Compare
obfusk
reviewed
Aug 20, 2024
obfusk
reviewed
Aug 20, 2024
TheLastProject
force-pushed
the
refactor/updateLoyaltyCardFromBundle
branch
from
5feb68b
to
78d3abe
Compare
TheLastProject
force-pushed
the
refactor/updateLoyaltyCardFromBundle
branch
5 times, most recently
from
94ab35d
to
7c6dd34
Compare
This allows us to send any (partial) loyalty card into the edit activity, granting us greater flexibility in what kind of scan result we can parse
TheLastProject
force-pushed
the
refactor/updateLoyaltyCardFromBundle
branch
3 times, most recently
from
9ec00b5
to
c5133c6
Compare
TheLastProject
force-pushed
the
refactor/updateLoyaltyCardFromBundle
branch
from
c5133c6
to
4f7cb7d
Compare
obfusk
reviewed
Sep 7, 2024
app/src/test/java/protect/card_locker/LoyaltyCardViewActivityTest.java
Outdated
Show resolved
Hide resolved
app/src/main/java/protect/card_locker/LoyaltyCardEditActivity.java
Outdated
Show resolved
Hide resolved
app/src/main/java/protect/card_locker/LoyaltyCardEditActivity.java
Outdated
Show resolved
Hide resolved
obfusk
reviewed
Sep 10, 2024
obfusk
reviewed
Sep 10, 2024
obfusk
reviewed
Sep 10, 2024
TheLastProject
force-pushed
the
refactor/updateLoyaltyCardFromBundle
branch
from
22bb8b2
to
521e6c5
Compare
TheLastProject
force-pushed
the
refactor/updateLoyaltyCardFromBundle
branch
from
521e6c5
to
5ba810b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to send any (partial) loyalty card into the edit activity, granting us greater flexibility in what kind of scan result we can parse