[ENG-2490] Upgrade ember to v3.26 #1203

fabmiz · 2021-05-06T21:17:10Z

Ticket: ENG-2490
Feature flag: n/a

Purpose

Upgrade core ember-* to v3.26 (latest stable) + required dependency upgrades

Developer experience

faster builds and rebuilds with typescript 4 and latest ember-cli-typescript (perf: don't use middleware if has build typed-ember/ember-cli-typescript#1148)
support for optional chaining and null coalescing operators with latest ember-cli-babel and ember-cli-typescript
async tasks and better types around ember-concurrency tasks via ember-concurrency-async and ember-concurrency-ts
better linting with typescript-eslint
more addons have adopted TS and are shipping their own types.

App user experience

some speedup with most (heavily used) upgrade to modern ember (glimmer and tracked properties)

Summary of Changes

Changes fall into these categories:

Dependency upgrades and addressing breaking changes
Async tasks
ember-data -> @ember-data
OsfButton -> BsButton
nodeLicense validations are now nested

Upgraded outside ember-cli-update

ember-concurrency: 1.x -> 2.x (upgrade guide)
ember-bootstrap: 3.x -> 4.x (breaking changes, more breaking changes)
ember-changeset: 2.x -> 3.x (Changelog; v3 drops support for ie 11; major rewrite)
ember-changeset-validations: 2.x -> 3.x (breaking: drops support for <3.13; node < 10; Changelog)
ember-power-select: 2.x -> 4.x (breaking changes 2.x -> 3.x, 3.x -> 4.x)
ember-basic-dropdown: 1.x -> 3.x (breaking changes 1.x -> 2.x, more breaking changes)
ember-intl: 4.x -> 5.x (breaking changes)
ember-cli-typescript: 3.x -> 4.x (breaking changes, more, moar)
typescript: 3.x -> 4.x (new features announcing-typescript-4-0, typescript-4-1-beta)
ember-cli-mirage: 1.x -> 2.x (breaking changes; drop support for node 8)
ember-cli-meta-tags: 5.x -> 6.x (diff; just a node version bump)
ember-composable-helpers: 2.x -> 4.x (Changelog 2.x -> 3.x , 3.x -> 4.x)
ember-page-title: 5.x -> 6.x (breaking change)
ember-qunit: 4.x -> 5.x (migration guide, breaking changes)
ember-engines: 0.8.2 -> 0.8.13 (notable changes)
eslint: 6.x -> 7.x

Upgraded via ember-cli-update

ember-source, ember-cli, ember-data: 3.16 -> 3.26
- release notes: ember-3-17, ember-3-18, ember-3-19, ember-3-20, ember-3-21, ember-3-22, ember-3-23, ember-3-24, ember-3-25, ember-3-26
@glimmer/component, @glimmer/component: 1.0.0 -> 1.0.4
ember-cli-app-version: 3.x -> 5.x
ember-cli-babel: 7.17.2 -> 7.26.5
ember-cli-htmlbars: 4.x -> 5.x
ember-template-lint: 2.x -> 3.x
ember-auto-import: 1.5.3 -> 1.11.2
ember-cli-terser (replaced ember-cli-uglify)
ember-resolver: 5.x -> 8.x

New addons

ember-concurrency-async (support for async tasks)
ember-concurrency-ts (helpers for async tasks)

eslint plugins: eslint-plugin-import, eslint-plugin-node, eslint-plugin-prettier, eslint-plugin-ember-concurrency

Removed addons

ember-youtube (unused and outdated)
ember-cli-uglify (replaced by ember-cli-terser)
tslint (dropped in favor of typescript-eslint)
tslint-consistent-codestyle (dropped bc it's tslint plugin)
tslint-eslint-rules (dropped bc it's tslint plugin)
ember-oo-modifiers (replaced by ember-modifier)
ember-concurrency-test-waiter (usage replaced by @ember/test-helpers waitFor)
ember-concurrency-decorators (decorators are now part of ember-concurrency v2)

Side Effects

QA Notes

Co-Authored-By: Brian Geiger <bgeiger@pobox.com>

…ivate-in-element]

Notable Changes Polyfills have been removed entirely and with it the need to bundle the pluralization rules as they now come from the native Intl.PluralRules API Intl.MessageFormat parser and compiler updated which changes how text and tags are escaped Breaking Changes Node 8 support dropped Intl.RelativeTime polyfill has been replaced with the native API which behaves entirely different than the previous older spec implementation. Read more in the Migration Document Escaping text has changed and HTML tags now need to be escaped. Read how in the Migration Document Removes shortNumber formatting in favor of newly added native implementation using the "notation": "compact" parameter for Intl.NumberFormat i.e.,

… types

https://github.com/emberjs/ember-qunit/blob/master/docs/migration.md

https://github.com/ember-cli/ember-cli-htmlbars/tree/0e3ef495412bb75096d1468d0771e97c0afb8d1b#tagged-template-usage--migrating-from-htmlbars-inline-precompile

ember-bootstrap/ember-bootstrap#1104

Replace usage with <BsButton> Why: subclassing ember-bootstrap component classes no longer supported ember-bootstrap/ember-bootstrap#1104

https://github.com/emberjs/rfcs/blob/master/text/0395-ember-data-packages.md

aaxelb

awesome work! i've looked at 200/831 files so far with only minor comments -- will circle back and skim the rest....

.eslintrc.js

app/adapters/osf-adapter.ts

app/adapters/collection.ts

app/adapters/user-registration.ts

app/packages/registration-schema/validations.ts

app/services/current-user.ts

app/transforms/node-license.ts

app/utils/capture-exception.ts

app/utils/default-to.ts

aaxelb

outstanding ✨ ⛰️

had more comments, but nothing major

i already feel a whole lot better about ember-osf-web being held up as the big example for ember with typescript

config/deprecation-workflow.js

lib/osf-components/addon/components/contributor-list/unregistered-contributor/template.hbs

lib/osf-components/addon/components/file-icon/component.ts

lib/osf-components/addon/components/node-category-picker/template.hbs

lib/osf-components/addon/components/paginated-list/has-many/component.ts

node-tests/fixtures/blueprints/osf-model/model.ts

package.json

tests/acceptance/dashboard-test.ts

tests/engines/registries/acceptance/draft/draft-test.ts

tests/unit/services/ready-test.ts

aaxelb

🍡 🎼

Fix noteworthy-and-popular-project tooltip

fabmiz mentioned this pull request May 6, 2021

[WIP][No ticket]ember-concurrency-async tasks #1139

Closed

fabmiz and others added 29 commits May 7, 2021 08:45

Move handbook; remove ember-cli-addon-docs

32ddab4

Co-Authored-By: Brian Geiger <bgeiger@pobox.com>

Remove ember-oo-modifier; use ember-modifier; remove array helper

c61d5cb

ember-cli-update to 3.20 lts

2955c84

Silence type check error for now

bb11026

Upgrade ember-composable-helpers; fix conflict with ember's array helper

8879072

Upgrade ember-basic-dropdown #in-element deprecation

28b7635

Upgrade ember-boostrap, ember-powerselect [deprecation id: glimmer.pr…

a0cc78f

…ivate-in-element]

Upgrade ember-page-title [deprecation id: glimmer.private-in-element]

2019d78

Upgrade ember-cli-meta-tags [deprecation id: glimmer.private-in-element]

c76705a

Upgrade ember-cli-mirage to v2

0da835f

Remove unused ember-youtube addon

b0fdb71

Add ember-cli-deprecation-workflow

7077163

Upgrade ember-cli-typescript@latest

37cb6e5

Turn on skipLibCheck ¯\_(ツ)_/¯

3747967

Remove defaultTo usage

bf4b5e3

Fix broke types

d681cd6

Upgrade ember-changeset; ember-changeset-validations; TODO: merge new…

4984323

… types

Include/re-map app-components, config files; exclude handbook-docs

5666b56

Upgrade ember-qunit v5

cddcf79

https://github.com/emberjs/ember-qunit/blob/master/docs/migration.md

Upgrade ec to v2; remove ember-concurrency-decorators

fd10ec6

ec-async, ec-ts, remove ec-test-waiter

1564cb0

Include config files

263c9c9

Import hbs helper from ember-cli-htmlbars

7283b27

https://github.com/ember-cli/ember-cli-htmlbars/tree/0e3ef495412bb75096d1468d0771e97c0afb8d1b#tagged-template-usage--migrating-from-htmlbars-inline-precompile

Declare ec-async as a dependency in in-repo-addon/engine package.json

6dff433

Use @ember/test-waiters waitFor

d748d96

ember-bootstrap: remove use of ember-boostrap 3.x deprecated arguments

21f6295

ember-bootstrap/ember-bootstrap#1104

ember-bootstrap: remove osf-button component

c201178

Replace usage with <BsButton> Why: subclassing ember-bootstrap component classes no longer supported ember-bootstrap/ember-bootstrap#1104

Pin dropzone.js to 5.5.1

f8f861b

fabmiz added 7 commits May 14, 2021 17:05

Address CR comments

497f085

Remove use of DS.Promise*

dae261d

https://github.com/emberjs/rfcs/blob/master/text/0395-ember-data-packages.md

Fix some types

660e18e

Fix osf-navbar bc ember-bootstrap upgrade

aa163d1

Merge latest develop; fix conflicts

b384fb1

Remove extra import

2e6bcc6

Fix probabilistic failing test

b722a47

fabmiz requested a review from aaxelb May 19, 2021 14:47

fabmiz added 3 commits May 19, 2021 12:09

percy: fix registration stage dropdown

ded3b1d

chore: fix missing social media fa icons

037371a

Do not use double single quotes inside html tags

8b2dec0

aaxelb reviewed May 19, 2021

View reviewed changes

aaxelb previously approved these changes May 20, 2021

View reviewed changes

fabmiz added 2 commits May 20, 2021 12:38

percy: Fix status-banner css

73923ff

Respond to CR

60b87f8

fabmiz dismissed aaxelb’s stale review via 60b87f8 May 21, 2021 20:32

fabmiz added 4 commits May 24, 2021 16:48

Fix linting errors

5cc249b

percy: fix missing navbar

26f227d

Fix ready service tests

019fb6f

Fix ready service tests

f67fb1f

aaxelb previously approved these changes May 26, 2021

View reviewed changes

Fix institution carousel

aaec782

Fix noteworthy-and-popular-project tooltip

fabmiz dismissed aaxelb’s stale review via aaec782 May 27, 2021 13:56

fabmiz added 4 commits May 27, 2021 12:56

percy: Fix responsive-dropdown usage

66e7eba

percy: fix osf-dropdown auth-dropdown

f3db489

percy: fix connected emails form

afaaddb

Merge branch 'develop' into ember-24-lts

9835159

adlius approved these changes Jun 2, 2021

View reviewed changes

fabmiz merged commit 59a18ae into develop Jun 2, 2021

fabmiz added this to the 21.6.0 milestone Jun 28, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ENG-2490] Upgrade ember to v3.26 #1203

[ENG-2490] Upgrade ember to v3.26 #1203

fabmiz commented May 6, 2021 •

edited

Loading

aaxelb left a comment

aaxelb left a comment

aaxelb left a comment

[ENG-2490] Upgrade ember to v3.26 #1203

[ENG-2490] Upgrade ember to v3.26 #1203

Conversation

fabmiz commented May 6, 2021 • edited Loading

Purpose

Summary of Changes

Side Effects

QA Notes

aaxelb left a comment

Choose a reason for hiding this comment

aaxelb left a comment

Choose a reason for hiding this comment

aaxelb left a comment

Choose a reason for hiding this comment

fabmiz commented May 6, 2021 •

edited

Loading