Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-6195] Fix admin confirmation link generation and handling #10734

Conversation

uditijmehta
Copy link
Contributor

@uditijmehta uditijmehta commented Sep 5, 2024

Purpose

Fix admin confirmation link generation and handling

Changes

  • Added logic to generate/refresh confirmation links when missing or expired.
  • Integrated new link generation logic into the admin panel.

Ticket

ENG-6195

Copy link
Member

@mfraezz mfraezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One relatively small refactor recommended, which should actually simplify this problem. Also, adding a couple unit tests for this behavior would be a boon.

Pass complete :octocat:

osf/utils/users.py Outdated Show resolved Hide resolved
admin/users/views.py Show resolved Hide resolved
@uditijmehta uditijmehta force-pushed the feature/admin-confirmation-link-fix branch from 708841d to 04a5e5f Compare October 9, 2024 13:37
Copy link
Member

@mfraezz mfraezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change/clean-up, otherwise LGTM :octocat:

osf/utils/users.py Outdated Show resolved Hide resolved
Copy link
Member

@mfraezz mfraezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :octocat:

@mfraezz mfraezz changed the base branch from feature/b-and-i-24-14 to feature/b-and-i-24-20 October 9, 2024 17:53
@mfraezz mfraezz merged commit 0fc98f4 into CenterForOpenScience:feature/b-and-i-24-20 Oct 9, 2024
6 checks passed
cslzchen added a commit that referenced this pull request Oct 30, 2024
[ENG-6195] Fix admin confirmation link generation and handling #10734
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants