-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENG-6195] Fix admin confirmation link generation and handling #10734
[ENG-6195] Fix admin confirmation link generation and handling #10734
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One relatively small refactor recommended, which should actually simplify this problem. Also, adding a couple unit tests for this behavior would be a boon.
Pass complete
708841d
to
04a5e5f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small change/clean-up, otherwise LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
0fc98f4
into
CenterForOpenScience:feature/b-and-i-24-20
[ENG-6195] Fix admin confirmation link generation and handling #10734
Purpose
Fix admin confirmation link generation and handling
Changes
Ticket
ENG-6195