[ENG-6242] Resolve issue with updating preprint fields and validation errors

[uditijmehta]

Purpose

Fix form validation issues in the preprint model and serializer.

Changes

• Updated preprint model to correctly handle validation.
• Modified serializer logic to properly manage field validation.

Ticket

ENG-6242

[brianjgeiger]

I think the changes to the model are good ones, but I think that we are risking losing data from API requests silently if we go with this as a complete solution. There'll need to be some modifications made to the tests and to the serializer functions, I believe.

[brianjgeiger]

Don't merge this, because it's a hotfix and we'll be going through that workflow for it.

It's not the way I expected this to be resolved, but it has the advantage of clearing out bad data if someone uses the old workflow that the original preprints app used, where the newly emptied fields would just not be included in the payload.

[brianjgeiger]

@uditijmehta Could you resolve the conflicts by merging master into this branch?

[cslzchen]

Late to the CR party, one suggestion and one potential blocker?

• I think we can remove handle_author_assertions() since we have removed the only usage of it.
• One crucial part in handle_author_assertions() was not ported to the "expanded" if statements: admin permission check. This is not testable by QA due to the assertion page disabled by FE but I think WRITE contributor can use API to change it. Probably a blocker?

[brianjgeiger]

@cslzchen So we need to make sure to require admin permissions to do author assertions before we move forward is the suggestion?

[cslzchen]

Yes, I think so.

[brianjgeiger]

@uditijmehta Could you make that change, and also add a test for that case?

[brianjgeiger]

New changes seem good to me. @cslzchen?

[cslzchen]

• I see we have two parts of the same/similar check, one is R344-R410 with the admin check patch while the other is R491-R551 without the admin patch. Maybe duplicate / left-over code?

• In addition, we should remove this method def handle_author_assertions(self, preprint, validated_data, auth): ...

[cslzchen]

LGTM 🎆

[cslzchen]

I cherry-picked 6 commits (and force pushed back) since the original branch has develop changes which should not be released to production.

Original branch has been backed up in https://github.com/cslzchen/osf.io/tree/hotfix/form-validation-issues-backup.