[ENG-6435] fix: duplicate reports when run for past years #10800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaxelb
force-pushed
the
fix/6435-report-timestamps
branch
from
1e639b0 to
5d44b9c
Compare
cslzchen
approved these changes
Nov 15, 2024
mfraezz
merged commit eadb41f
into
CenterForOpenScience:feature/b-and-i-24-22
6 checks passed
Johnetordoff
pushed a commit
to Johnetordoff/osf.io
that referenced
this pull request
Dec 11, 2024
…terForOpenScience/osf.io into institutional-access-user-message-arb * 'feature/institutional_access' of https://github.com/CenterForOpenScience/osf.io: add user message read/write permissions to full add new user message oauth scope and throttling classes Fix backfill, report Update changelog and bump versions Follow-up fix for target/next (start/end) month Fix failures caused by base class MonthlyReporter update [ENG-6506] Fix: counted-usage clobbers (CenterForOpenScience#10799) [ENG-6435] Fix: duplicate reports when run for past years (CenterForOpenScience#10800) Add PrivateSpamMetricsReport (CenterForOpenScience#10791) [ENG-4438] Add OOPSpam and Akismet metrics to spam report (CenterForOpenScience#10783) [ENG-6364] Migrate Preprint Affilations (CenterForOpenScience#10787)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
prevent duplicate reports when monthly/daily reports are run for past years
Changes
set
timestampbased onreport_date/report_yearmonth, so it's indexed by reporting period rather than when the reporter is runQA Notes
Please make verification statements inspired by your code and what your code touches.
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
Ticket