Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(#80): 회원 탈퇴 추가 #102

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Conversation

tmddus2
Copy link
Collaborator

@tmddus2 tmddus2 commented Aug 28, 2024

작업 사항

close #80

고민한 점들

  • hard delete vs soft delete

    • 회원 탈퇴해도 리뷰는 남기기로 하는 요구사항이 있어서 soft delete 선택
  • 탈퇴 후 7일간 재가입 불가

    • 탈퇴 시점 deletedAt 적어두고 7일 안 됐으면 재가입 안 시킴
  • 탈퇴한 사용자 예외처리 어디서?

    • GPT 물어보니까 AOP@ControllerAdvice 말하던데
    • token 안에 들어있는 id 값 찾아주는 argument resolver가 있으니까 그 안에서 걸려줌
      • 예전에는 탈퇴가 없었기 때문에 무조건 있는 user라는 보장이 있었는데, 이제는 id 값에 해당하는 user가 없을 수도 있기 때문에 걸러줌

@tmddus2 tmddus2 self-assigned this Aug 28, 2024
@tmddus2 tmddus2 merged commit 9b53d18 into main Aug 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant