Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(#103): 스탬프 관련 이슈들 수정 #104

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

tmddus2
Copy link
Collaborator

@tmddus2 tmddus2 commented Aug 28, 2024

작업 사항

  • closed 103

고민한 점들

private void upgradeMembership(User user) {
	int numOfReviews = reviewRepository.countAllByUser(user);
	user.updateMembership(numOfReviews);
	userRepository.save(user);
}

update 안 될 때도 매번 save로 덮어쓰게 하면 안 좋지 않을까? 코드 더러워지는건 또 싫은데... 고민고민

@tmddus2 tmddus2 self-assigned this Aug 28, 2024
@tmddus2 tmddus2 merged commit 7aa6a64 into main Aug 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant