Fix RFC 2302 to support unit structs, fn pointers, and use value namespace instead for exprs #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nit structs, change reference explanation, etc. + consequence changes.
text/0000-tuple-struct-self-ctor.md
Outdated
| Rust (now) allows usage of `Self(v0, v1, ..)` inside inherent | ||
| and trait `impl`s of tuple structs, either when mentioning the | ||
| tuple struct directly in the `impl` header, or via a type alias. | ||
| Rust (now) allows usage of `Self(v0, v1, ..)` inside inherent and |
There was a problem hiding this comment.
I find this now confusing. Does it mean before or after the RFC?
text/0000-tuple-struct-self-ctor.md
Outdated
| Rust (now) allows usage of `Self(v0, v1, ..)` inside inherent and | ||
| trait `impl`s of tuple structs, either when mentioning the tuple struct | ||
| directly in the `impl` header, or via a type alias. | ||
| This usage is permitted both in expression and pattern contexts. |
There was a problem hiding this comment.
I think I would prefer if we can rewrite this Reference-Level Explanation to be a little more "implementation focused". Right now it reads a bit to me like restating the premise of the RFC. For example, I think I would prefer to say:
When entering one of the following contexts, the value namespace is extended with Self which maps to the tuple constructor fn (or constant, in the case of a unit struct):
- inherent impls where the
Selftype is a tuple or unit struct - trait impls where the
Selftype is a tuple or unit struct
text/0000-tuple-struct-self-ctor.md
Outdated
| directly in the `impl` header, or via a type alias. | ||
| This usage is permitted both in expression and pattern contexts. | ||
|
|
||
| Furthermore, `Self`, when referring to a tuple struct, can be legally coerced |
There was a problem hiding this comment.
I think this basically follows from the description I gave before; it could be rewritten to say "This should allow Self to be legally coerced..."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Selfis permitted as a function pointer,