Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove serde as direct dependency #53

Merged
merged 1 commit into from
Apr 18, 2023
Merged

chore: remove serde as direct dependency #53

merged 1 commit into from
Apr 18, 2023

Conversation

jiacai2050
Copy link
Member

Which issue does this PR close?

Closes #

Rationale for this change

Clean unused dep

What changes are included in this PR?

Remove direct dependency on serde

 (main)$ cargo tree -i serde
serde v1.0.152
├── mysql v23.0.1
│   └── sqlness v0.4.3 (/Users/jiacai/code/misc/sqlness/sqlness)
│       └── sqlness-cli v0.4.3 (/Users/jiacai/code/misc/sqlness/sqlness-cli)
├── mysql_common v0.29.2
│   └── mysql v23.0.1 (*)
├── rust_decimal v1.28.1
│   └── mysql_common v0.29.2 (*)
├── serde_json v1.0.93
│   ├── mysql v23.0.1 (*)
│   └── mysql_common v0.29.2 (*)
└── toml v0.5.11
    └── sqlness v0.4.3 (/Users/jiacai/code/misc/sqlness/sqlness) (*)

Are there any user-facing changes?

No

How does this change test

CI

@jiacai2050 jiacai2050 requested a review from waynexia April 18, 2023 04:28
@waynexia waynexia enabled auto-merge April 18, 2023 04:34
@waynexia waynexia added this pull request to the merge queue Apr 18, 2023
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great 👍

Merged via the queue into main with commit 4d1687c Apr 18, 2023
@jiacai2050 jiacai2050 deleted the chore-clean-dep branch April 18, 2023 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants