Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support postgres wire protocol #62

Merged
merged 10 commits into from
Sep 28, 2023
Merged

feat: support postgres wire protocol #62

merged 10 commits into from
Sep 28, 2023

Conversation

Lilit0x
Copy link
Contributor

@Lilit0x Lilit0x commented Sep 14, 2023 •
edited by jiacai2050
Loading

Which issue does this PR close?

Closes #44

What changes are included in this PR?

Adding support for PostgreSQL databases to run tests against

Are there any user-facing changes?

  • Multiple options for the type argument

How does this change test

CI

@CLAassistant
Copy link

CLAassistant commented Sep 14, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Lilit0x
Copy link
Contributor Author

Lilit0x commented Sep 14, 2023

@jiacai2050, I have the basic outline here, but I am quite stuck on how to integrate it with CLI through the EnvController seeing that it requires a DB type. And now, there are two types of DB.
So, I just repicated the EnvController trait for Postgres too and I know that's not the way to go, but I guess it is a starting point.

jiacai2050
jiacai2050 reviewed Sep 15, 2023
View reviewed changes
sqlness/src/database_impl/postgresql.rs Outdated Show resolved Hide resolved
sqlness-cli/src/main.rs Outdated Show resolved Hide resolved
@tanruixiang
Copy link
Contributor

@Lilit0x Hi, I've helped you make the appropriate changes based on the REVIEW, if you have time, please help with the REVIEW.

@jiacai2050 jiacai2050 changed the title Postgres Wire Protocol Support feat: support postgres wire protocol Sep 27, 2023
@jiacai2050 jiacai2050 force-pushed the feat/postgres_wire_protocol branch from 5485b00 to 668a868 Compare September 27, 2023 08:07
@tanruixiang tanruixiang force-pushed the feat/postgres_wire_protocol branch from afc37dd to 5f867b0 Compare September 28, 2023 02:50
@jiacai2050 jiacai2050 force-pushed the feat/postgres_wire_protocol branch from ef5183d to 3c3e64a Compare September 28, 2023 03:19
@jiacai2050 jiacai2050 force-pushed the feat/postgres_wire_protocol branch from 3c3e64a to a7f5c6b Compare September 28, 2023 03:22
jiacai2050
jiacai2050 approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 merged commit 8e1887e into CeresDB:main Sep 28, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiacai2050 jiacai2050 jiacai2050 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support PostgreSQL wire protocol
4 participants
@Lilit0x @CLAassistant @tanruixiang @jiacai2050