Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add basic examples #7

Merged
merged 5 commits into from
Dec 26, 2022
Merged

add basic examples #7

merged 5 commits into from
Dec 26, 2022

Conversation

jiacai2050
Copy link
Member

@jiacai2050 jiacai2050 commented Dec 26, 2022

Which issue does this PR close?

Part of #3

Rationale for this change

Add a basic examples.

What changes are included in this PR?

  1. Add basic example
  2. Fix fail_fast, it should return when first error arise.

Are there any user-facing changes?

How does this change test

cargo run --example basic -- examples/basic.toml

Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

examples/basic.toml Outdated Show resolved Hide resolved
println!("Case {} failed with error {:?}", case_name, e);
println!("Stopping environment {} due to previous error.", env);
break;
} else {
errors.push((case_name, e))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 🫣

@jiacai2050 jiacai2050 merged commit e96b85f into main Dec 26, 2022
@jiacai2050 jiacai2050 deleted the feat-examples branch December 26, 2022 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants