Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default log levels #68

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Fix default log levels #68

merged 1 commit into from
Sep 15, 2023

Conversation

javagl
Copy link
Contributor

@javagl javagl commented Sep 15, 2023

The default log levels had been wrong, limiting the level that could be used for the console to info.

  • The globalLogLevel is the level that the logger itself uses
  • The consoleLogLevel and fileLogLevel can be imagined as additional "filters" that are applied "behind the logger"

So previously, the level for the console target was
const consoleLogLevel = "info";
and this value cannot be changed. So even when the logger was set to trace afterwards, the console still displayed nothing more than info.

@lilleyse lilleyse merged commit 60fda20 into main Sep 15, 2023
2 checks passed
@lilleyse lilleyse deleted the fix-default-log-levels branch September 15, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants