Move Batch Table hierarchy to an extension #305
Conversation
lilleyse
force-pushed
the
tileset.json-edits
branch
from
45f11b8 to
f0e031b
Compare
Hm good question... maybe core extensions should have the |
Just include me and Patrick. |
Check what glTF does - but I'm ok either way. |
TileFormats/BatchTable/README.md
Outdated
| @@ -167,342 +158,6 @@ var geographicArray = new Float64Array(batchTableBinary.buffer, byteOffset, geog | |||
| var geographicOfFeature = positionArray.subarray(batchId * numberOfComponents, batchId * numberOfComponents + numberOfComponents); // Using subarray creates a view into the array, and not a new array. | |||
| ``` | |||
|
|
|||
| ## Batch Table Hierarchy | |||
|
|
|||
| The standard batch table is suitable for datasets composed of features with the same sets of properties. However, some datasets have more complex metadata structures such as feature types or feature hierarchies that are not easy to represent as parallel arrays of properties. The Batch Table Hierarchy provides more flexibility for these cases. | |||
There was a problem hiding this comment.
It might be worthwhile to keep just this section but point to the extension for more details.
|
|
||
| ```json | ||
| { | ||
| "CESIUM_batch_table_hierarchy" : { |
There was a problem hiding this comment.
CESIUM_batch_table_hierarchy should be contained within an extensions objects.
|
|
||
| ```json | ||
| { | ||
| "HIERARCHY" : { |
There was a problem hiding this comment.
Use extensions and CESIUM_batch_table_hierarchy objects.
|
|
||
| ```json | ||
| { | ||
| "HIERARCHY" : { |
| "Height" : [...], | ||
| "Longitude" : [...], | ||
| "Latitude" : [...], | ||
| "HIERARCHY" : {...} |
There was a problem hiding this comment.
Same comment - and change the name in the description above.
|
Thanks @lilleyse ! Updated, and also updated the figures to reflect the changes. |
| * [Overview](#overview) | ||
| * [Motivation](#motivation) | ||
| * [Batch table JSON schema updates](#batch-table-json-schema-updates) | ||
| * [3DTILES_batch_table_hierarchy](#3DTILES_batch_table_hierarchy) |
There was a problem hiding this comment.
The link isn't working, it should be lower case.
|
|
||
| Batch Table Hierarchy, parking lot: | ||
|
|
||
|  |
There was a problem hiding this comment.
Oh good catch about the pictures!
The json formatting is a little off on this picture. The other picture looks good.
|
Thanks @lilleyse, fixed! |
|
👍 |
Fixes #303
CESIUM_batch_table_hierarchythe name of the extension we would like to use? Is this a vendor extension? What prefix should we use for core extensions otherwise?additionalProprtiesfield? or is that covered byextensionsandextrasnow?