-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fully support specifying a custom ellipsoid #890
Conversation
Cesium3DTilesSelection/include/Cesium3DTilesSelection/TilesetOptions.h
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @azrogers, just a few comments below.
Cesium3DTilesSelection/include/Cesium3DTilesSelection/TilesetOptions.h
Outdated
Show resolved
Hide resolved
Cesium3DTilesSelection/include/Cesium3DTilesSelection/Tileset.h
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes @azrogers !
From what I can tell, all review comments have been resolved. I'll give @kring another chance to chime in though...
One clarifying question from me, do we still need CESIUM_DISABLE_DEFAULT_ELLIPSOID
? If not, can we remove it? And if so, is it useful enough to put in our release notes so that other developers can use it?
(Btw, I appreciate the sheer number of files you needed to change for this PR, quite impressive!)
I asked Ashley to add this because I think it's very useful, such as when adding alternate ellipsoid support to a new product that uses cesium-native. Adding it to the release notes seems like a good idea. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting close now!
Cesium3DTilesSelection/include/Cesium3DTilesSelection/BoundingVolume.h
Outdated
Show resolved
Hide resolved
CesiumGeospatial/include/CesiumGeospatial/S2CellBoundingVolume.h
Outdated
Show resolved
Hide resolved
CesiumRasterOverlays/include/CesiumRasterOverlays/RasterOverlayUtilities.h
Show resolved
Hide resolved
@kring Updated the PR based on the review. BoundingRegion, S2CellBoundingVolume and Tileset no longer store copies of the ellipsoid, which required a good number of changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more small changes, I think this should be the last of it!
Thanks @azrogers! |
cesium-native already allows specifying a custom ellipsoid with most of its operations. This change removes the few places where the WGS84 ellipsoid was hardcoded, allowing all of cesium-native to be used with other ellipsoids. This is necessary to support CesiumGS/cesium-unreal#366.